New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter sanitize before compiling volt #12133
Conversation
4d3c73f
to
6ef079c
Compare
@niden did you want me to sort this one out? |
@CameronHall If you can yes please. |
I won't be able to get this done anytime soon. If you remind me what it's supposed to do, I can take a look at it and chip away. |
If it is a fix for a real problem, let's apply it before beta release. But first I would like to see a script to reproduce the bug |
The way I deciphered this since there was no description or rationale behind this, was to introduce a way to manipulate HTML after it has been compiled. The particular PR introduces this functionality and the supplied filter class strips whitespaces, line feeds etc., thus reducing the output on screen. I do not think that this should be part of Phalcon. Services such as Varnish or Cloudflare can offer this functionality without having to change your code. @pedro151 Thank you so much for the contribution, however I will close this. If later on the community is interested in something like this we can reintroduce this. |
No description provided.