Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter sanitize before compiling volt #12133

Closed
wants to merge 2 commits into from
Closed

Conversation

pedro151
Copy link

No description provided.

@sergeyklay sergeyklay added this to the 3.1.0 milestone Aug 12, 2016
@sjinks sjinks reopened this Apr 26, 2017
@sergeyklay sergeyklay modified the milestones: 3.2.0, 4.0.0 Jun 18, 2017
@CameronHall
Copy link
Contributor

CameronHall commented Jan 18, 2019

@niden did you want me to sort this one out?

@niden niden added new feature request Planned Feature or New Feature Request and removed New Feature Request labels Mar 11, 2019
@niden
Copy link
Sponsor Member

niden commented Jul 12, 2019

@CameronHall If you can yes please.

@CameronHall
Copy link
Contributor

CameronHall commented Jul 12, 2019

I won't be able to get this done anytime soon. If you remind me what it's supposed to do, I can take a look at it and chip away.

@sergeyklay
Copy link
Member

If it is a fix for a real problem, let's apply it before beta release. But first I would like to see a script to reproduce the bug

@niden
Copy link
Sponsor Member

niden commented Jul 12, 2019

The way I deciphered this since there was no description or rationale behind this, was to introduce a way to manipulate HTML after it has been compiled. The particular PR introduces this functionality and the supplied filter class strips whitespaces, line feeds etc., thus reducing the output on screen.

I do not think that this should be part of Phalcon. Services such as Varnish or Cloudflare can offer this functionality without having to change your code.

@pedro151 Thank you so much for the contribution, however I will close this. If later on the community is interested in something like this we can reintroduce this.

@niden niden closed this Jul 12, 2019
@niden niden added 4.0 wontfix The issue will not be fixed or implemented labels Jul 12, 2019
@niden niden removed this from the 4.0.0 milestone Dec 9, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Dec 9, 2019
@niden niden moved this from In progress to Done in 4.0.0 Release Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request wontfix The issue will not be fixed or implemented
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants