New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] CLI parameters now work like MVC parameters #12375

Closed
wants to merge 1 commit into
base: 4.0.x
from

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

SidRoberts commented Oct 30, 2016

Taking this as an example:

php cli.php greeting morning Sid Roberts

Before:

class GreetingTask extends \Phalcon\Cli\Task
{
    public function morningAction($params)
    {
        echo "Good morning " . $params[0] . " " . $params[1];
    }
}

Now:

class GreetingTask extends \Phalcon\Cli\Task
{
    public function morningAction($firstName, $lastName)
    {
        echo "Good morning " . $firstName . " " . $lastName;
    }
}

This, of course, makes Dispatcher::callActionMethod() redundant.

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch 3 times, most recently from d395f1b to 1169273 Oct 30, 2016

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 31, 2016

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from 1169273 to c79fb34 Nov 27, 2016

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from c79fb34 to 9f0a7de Jan 30, 2017

@sergeyklay sergeyklay closed this Mar 22, 2017

@sergeyklay sergeyklay reopened this Mar 22, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from 9f0a7de to d3f3007 Mar 25, 2017

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from d3f3007 to be63a49 May 2, 2017

@SidRoberts SidRoberts changed the base branch from 3.0.x to 4.0.x May 2, 2017

@SidRoberts SidRoberts changed the base branch from 4.0.x to 3.1.x May 2, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from be63a49 to 4cdf8f2 May 2, 2017

@SidRoberts SidRoberts changed the base branch from 3.1.x to 4.0.x May 2, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch 3 times, most recently from 0cf7f63 to f2d85e2 May 2, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from cf1abda to 53683c6 Jun 18, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 53683c6 to 4a7aa3c Jul 10, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch 2 times, most recently from 51fcab0 to 5227953 Aug 1, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 4a7aa3c to 44ce3c6 Aug 13, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch 5 times, most recently from 9713270 to 4766a58 Aug 14, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-task-params branch from 4766a58 to e412efb Aug 24, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 2c6328f to cafc459 May 28, 2018

@niden niden added this to In progress in 4.0 Release Nov 29, 2018

@CameronHall CameronHall referenced this pull request Dec 4, 2018

Merged

CLI parameters now work like MVC parameters. #13630

3 of 3 tasks complete

@niden niden moved this from In progress to Done in 4.0 Release Dec 9, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 9, 2018

Implemented in #13630

@niden niden closed this Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment