Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] CLI parameters now work like MVC parameters #12375

Closed
wants to merge 1 commit into from
Closed

[4.0.0] CLI parameters now work like MVC parameters #12375

wants to merge 1 commit into from

Conversation

SidRoberts
Copy link
Contributor

Taking this as an example:

php cli.php greeting morning Sid Roberts

Before:

class GreetingTask extends \Phalcon\Cli\Task
{
    public function morningAction($params)
    {
        echo "Good morning " . $params[0] . " " . $params[1];
    }
}

Now:

class GreetingTask extends \Phalcon\Cli\Task
{
    public function morningAction($firstName, $lastName)
    {
        echo "Good morning " . $firstName . " " . $lastName;
    }
}

This, of course, makes Dispatcher::callActionMethod() redundant.

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 31, 2016
@sergeyklay sergeyklay closed this Mar 22, 2017
@sergeyklay sergeyklay reopened this Mar 22, 2017
@sjinks sjinks closed this Apr 26, 2017
@sjinks sjinks reopened this Apr 26, 2017
@SidRoberts SidRoberts changed the base branch from 3.0.x to 4.0.x May 2, 2017 14:38
@SidRoberts SidRoberts changed the base branch from 4.0.x to 3.1.x May 2, 2017 14:42
@SidRoberts SidRoberts changed the base branch from 3.1.x to 4.0.x May 2, 2017 23:53
@niden niden added this to In progress in 4.0.0 Release Nov 29, 2018
@niden niden moved this from In progress to Done in 4.0.0 Release Dec 9, 2018
@niden
Copy link
Sponsor Member

niden commented Dec 9, 2018

Implemented in #13630

@niden niden closed this Dec 9, 2018
@SidRoberts SidRoberts deleted the v4-task-params branch April 8, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants