[WIP]3.1.x firewall #12561
Closed
[WIP]3.1.x firewall #12561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurigag
force-pushed
the
3.1.x-firewall
branch
from
13ec3b8
to
37f2853
Compare
Jurigag
force-pushed
the
3.1.x-firewall
branch
from
37f2853
to
e8de519
Compare
|
Could we reopen this issue? Looks like it didn't made it to 3.2.x branch. |
|
I will make it for 3.3 or 4.0, will see |
|
Is this still on the map for 4.0? |
|
Implemented in #14078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: this pr is adding Firewall component, way to protect routes against unauthorized roles to access certain routes. It's done using listener on dispatcher/micro on beforeExecute/afterBinding event.
In dispatcher you can either use Annotations or Acl based firewall. In micro there is only Acl based firewall.
Would appreciate any comments etc.
This PR is commits/changes from other PRs etc stuff so don't bother them, i will rebase everything if all will be merged.
Thanks
Related:
https://github.com/phalcon/cphalcon/issues/11389
#582