Need to check that response has not been already sent in phalcon/mvc/micro.zep #12668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to return a string value from a mapped function for an HTTP Method, and then catch that returned value by using Micro::getReturnedValue() method inside handler on Micro::after($handler), its overriding my response.
|
This is bug fix. |
|
Changelog updated. Since I could not install zephir on macox sierra, I could not tested. |
|
I mean unit test. |
sergeyklay
requested changes
Mar 8, 2017
There was a problem hiding this comment.
@Fabsolute In general I like this PR. Could you please provide a small test which covers these changes?
sergeyklay
requested changes
Mar 10, 2017
There was a problem hiding this comment.
FILE: /home/travis/build/phalcon/cphalcon/tests/unit/Mvc/MicroTest.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
451 | ERROR | [x] Expected 1 space after USE keyword; found 0
| | (Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterUse)
451 | ERROR | [x] Expected 1 space before opening brace; found 0
| | (Squiz.Functions.MultiLineFunctionDeclaration.SpaceBeforeBrace)
458 | ERROR | [x] Expected 1 space before opening brace; found 0
| | (Squiz.Functions.MultiLineFunctionDeclaration.SpaceBeforeBrace)
459 | ERROR | [x] Line indented incorrectly; expected at least 24
| | spaces, found 23
| | (Generic.WhiteSpace.ScopeIndent.Incorrect)
467 | ERROR | [x] The closing brace for the class must go on the next
| | line after the body
| | (PSR2.Classes.ClassDeclaration.CloseBraceAfterBody)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
sergeyklay
requested changes
Mar 10, 2017
tests/unit/Mvc/MicroTest.php
Outdated
| return "success"; | ||
| } | ||
| ); | ||
| $app->handle("/api"); |
There was a problem hiding this comment.
expect($micro->handle('/api'))->equals("success"); //❓ 
sergeyklay
force-pushed
the
3.1.x
branch
6 times, most recently
from
e6df98e
to
526d7bb
Compare
sergeyklay
force-pushed
the
3.1.x
branch
10 times, most recently
from
4d3c73f
to
6ef079c
Compare
|
Fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following :
Small description of change:
It is not possible to return a string value from a mapped function for an HTTP Method, and then catch that returned value by using Micro::getReturnedValue() method inside handler on Micro::after($handler), its overriding my response.
Thanks