Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed. threw RuntimeException, if db:beforeQuery() returned false #13040

Merged
merged 4 commits into from Aug 29, 2017

Conversation

kanehama
Copy link

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:
threw RuntimeException, if db:beforeQuery() returned false

Thanks

@kanehama
Copy link
Author

https://docs.phalconphp.com/ar/3.2/db-layer#events

"beforeQuery" supported stop operation. "YES"

@sergeyklay
Copy link
Member

@kanehama Could you please submit this PR to the 3.2.x branch? I'll cherry-pick it to the 4.0.x a bit later. Also update please the CHANGELOG.md. Thank you for contributing!

@kanehama kanehama changed the base branch from 4.0.x to 3.2.x August 29, 2017 03:53
@kanehama
Copy link
Author

Thank you for checking.
I changed it, is this OK?

@sergeyklay sergeyklay merged commit 587881d into phalcon:3.2.x Aug 29, 2017
@sergeyklay
Copy link
Member

Thank you

@kanehama kanehama deleted the fix_db_beforeQuery branch August 29, 2017 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants