Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile documentation update #13086

Merged
merged 2 commits into from Sep 24, 2017
Merged

Profile documentation update #13086

merged 2 commits into from Sep 24, 2017

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Sep 23, 2017 •
edited

Updated documentation to reflect new implementation.

Hello!

  • Type: documentation

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@ruudboon
Profile documentation update
692f2a8 
Updated documentation to reflect new implementation.
Should fix #1326
@sergeyklay
Copy link
Member

We don't add changes directly to stable branches or master. Could you please send this PR to the 3.2.x branch?

@ruudboon ruudboon changed the base branch from master to 3.2.x September 24, 2017 10:17
@ruudboon
Copy link
Member Author

ruudboon commented Sep 24, 2017 •
edited

Sorry edited the file in GitHub since it was only comments, didn't realise it was still on the master. Changed it now.

@sergeyklay sergeyklay self-assigned this Sep 24, 2017
@sergeyklay sergeyklay added this to the 3.2.x milestone Sep 24, 2017
@sergeyklay sergeyklay added the enhancement Enhancement to the framework label Sep 24, 2017
@sergeyklay sergeyklay merged commit ba87d33 into phalcon:3.2.x Sep 24, 2017
@sergeyklay
Copy link
Member

Thank you

@ruudboon ruudboon deleted the patch-1 branch September 25, 2017 05:57
@ruudboon ruudboon mentioned this pull request Oct 1, 2017
Merged
@ninjapanzer ninjapanzer mentioned this pull request Oct 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees

@sergeyklay sergeyklay

Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruudboon @sergeyklay