[NFR] Add cache timeout option support to the redis adapter #13414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cq-z
changed the title
|
@cq-z Could you please update change log too. Finally squash commits into a single commit to keep the history clean. This also will help me to cherry-pick these changes to the 4.0.x branch. Thank you for the patch. |
sergeyklay
changed the title
|
Thank you |
|
sorry no git rebase。。。 |
sergeyklay
pushed a commit
that referenced
this pull request
Jun 25, 2018
* feature: add redis cache timeout options * fix: add timeout parameter * test:add redis timeout test * docs: add changelog * Update change log [ci skip]
|
@cq-z I just squashed your PR using GitHub interface |
michanismus
added a commit
to michanismus/cphalcon
that referenced
this pull request
Jun 26, 2018
…halcon#13414)" This reverts commit 480a9c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change: Add cache timeout option support to the redis adapter
Thanks