Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/t13547 tag enhancements #13566

Closed
wants to merge 4 commits into from
Closed

Feature/t13547 tag enhancements #13566

wants to merge 4 commits into from

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Nov 1, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Changed Phalcon\Tag::getTitle(). It returns only the text set with setTitle(). If there has been prepend and append text it will be returned by default. It accepts prepend, append booleans to prepend or append the relevant text to the title.

Added Phalcon\Tag::renderTitle() that renders the title enclosed in <title> tags.

Thanks

@niden niden requested a review from sergeyklay November 1, 2018 20:34
@niden
Copy link
Sponsor Member Author

niden commented Nov 1, 2018

cc @sergeyklay

@niden niden added this to the 4.0.0 milestone Nov 1, 2018
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Nov 1, 2018
@niden niden self-assigned this Nov 1, 2018
@niden niden closed this Nov 1, 2018
@niden niden deleted the feature/T13547-tag-enhancements branch November 1, 2018 21:14
@niden niden restored the feature/T13547-tag-enhancements branch November 2, 2018 20:47
@niden niden deleted the feature/T13547-tag-enhancements branch November 2, 2018 20:48
@niden niden restored the feature/T13547-tag-enhancements branch November 2, 2018 20:50
@niden niden added this to Done in 4.0.0 Release Dec 7, 2018
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant