Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add offset to query builder #13600

Merged
merged 3 commits into from Nov 14, 2018
Merged

add offset to query builder #13600

merged 3 commits into from Nov 14, 2018

Conversation

Izopi4a
Copy link
Member

@Izopi4a Izopi4a commented Nov 13, 2018 •
edited by sergeyklay

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.

Small description of change:

Added Phalcon\Mvc\Model\Query\BuilderInterface::offset. Closes #13599.

Thanks

sergeyklay
sergeyklay previously requested changes Nov 13, 2018
View reviewed changes
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
@sergeyklay sergeyklay added New Feature Request new feature request Planned Feature or New Feature Request and removed New Feature Request labels Nov 13, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone Nov 13, 2018
@niden niden merged commit 1a01410 into phalcon:4.0.x Nov 14, 2018
@niden
Copy link
Sponsor Member

niden commented Nov 14, 2018

Thank you @Izopi4a

@niden niden added this to Done in 4.0.0 Release Dec 7, 2018
@CameronHall CameronHall mentioned this pull request Dec 12, 2018
Closed
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 17, 2019
@niden niden removed this from the 4.0.0 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees

@niden niden

Labels
new feature request Planned Feature or New Feature Request
Projects
No open projects
4.0.0 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izopi4a @niden @sergeyklay