Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Builder's GROUP BY field is now always an array #13962

Merged
merged 2 commits into from Apr 14, 2019

Conversation

@SidRoberts
Copy link
Member

commented Apr 8, 2019

Hello!

  • Type: bug fix
  • Link to issue: #11690

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Line 828 also blindly assumes that this->_group is an array.

@SidRoberts SidRoberts force-pushed the SidRoberts:query-builder-groupby branch from a7cf678 to f3a5a6f Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #13962 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13962      +/-   ##
==========================================
+ Coverage   67.87%   67.87%   +<.01%     
==========================================
  Files         469      469              
  Lines       94315    94319       +4     
==========================================
+ Hits        64014    64019       +5     
+ Misses      30301    30300       -1
Impacted Files Coverage Δ
ext/phalcon/mvc/model/query/builder.zep.c 74.86% <0%> (+0.05%) ⬆️
ext/phalcon/paginator/adapter/querybuilder.zep.c 81.67% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5fb65...97040ca. Read the comment docs.

@SidRoberts SidRoberts force-pushed the SidRoberts:query-builder-groupby branch from f3a5a6f to 6104fdb Apr 8, 2019

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Apr 9, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 9, 2019

@SidRoberts SidRoberts dismissed stale reviews from sergeyklay, CameronHall, and Jeckerson via 2fa8493 Apr 9, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:query-builder-groupby branch from 6104fdb to 2fa8493 Apr 9, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:query-builder-groupby branch from 2fa8493 to 0c34e91 Apr 14, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Thank you @SidRoberts

@niden

niden approved these changes Apr 14, 2019

@niden niden merged commit cd3e523 into phalcon:4.0.x Apr 14, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

4.0 Release automation moved this from In progress to Done Apr 14, 2019

@SidRoberts SidRoberts deleted the SidRoberts:query-builder-groupby branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.