Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Builder's GROUP BY field is now always an array #13962

Merged
merged 2 commits into from Apr 14, 2019
Merged

Query Builder's GROUP BY field is now always an array #13962

merged 2 commits into from Apr 14, 2019

Conversation

SidRoberts
Copy link
Contributor

@SidRoberts SidRoberts commented Apr 8, 2019 •
edited

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Line 828 also blindly assumes that this->_group is an array.

@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited

Codecov Report

Merging #13962 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13962      +/-   ##
==========================================
+ Coverage   67.87%   67.87%   +<.01%     
==========================================
  Files         469      469              
  Lines       94315    94319       +4     
==========================================
+ Hits        64014    64019       +5     
+ Misses      30301    30300       -1
Impacted Files Coverage Δ
ext/phalcon/mvc/model/query/builder.zep.c 74.86% <0%> (+0.05%) ⬆️
ext/phalcon/paginator/adapter/querybuilder.zep.c 81.67% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5fb65...97040ca. Read the comment docs.

Jeckerson
Jeckerson previously approved these changes Apr 8, 2019
View reviewed changes
CameronHall
CameronHall previously approved these changes Apr 9, 2019
View reviewed changes
sergeyklay
sergeyklay previously approved these changes Apr 9, 2019
View reviewed changes
@sergeyklay sergeyklay added this to In progress in 4.0.0 Release via automation Apr 9, 2019
@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 9, 2019
@niden niden added breaks bc Functionality that breaks Backwards Compatibility documentation Documentation required enhancement Enhancement to the framework new feature request Planned Feature or New Feature Request and removed enhancement Enhancement to the framework labels Apr 14, 2019
@niden
Copy link
Sponsor Member

niden commented Apr 14, 2019

Thank you @SidRoberts

@niden niden merged commit cd3e523 into phalcon:4.0.x Apr 14, 2019
4.0.0 Release automation moved this from In progress to Done Apr 14, 2019
@SidRoberts SidRoberts deleted the query-builder-groupby branch April 14, 2019 21:28
@niden niden added 4.0 and removed documentation Documentation required labels Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@sergeyklay sergeyklay sergeyklay left review comments

@Jeckerson Jeckerson Jeckerson left review comments

@CameronHall CameronHall CameronHall left review comments

Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
No open projects
4.0.0 Release
  
Done
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SidRoberts @niden @sergeyklay @Jeckerson @CameronHall