Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14810 - Model::cloneResult() to use setters #15171

Closed

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Oct 16, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG

Small description of change:

Seems like this issue still occurs using Zephir 0.12.19
Added test to verify it.

Thanks,
zsilbi

@zsilbi zsilbi marked this pull request as draft October 16, 2020 22:13
@zsilbi
Copy link
Member Author

zsilbi commented Oct 16, 2020

Will be fixed in v5.0

@zsilbi zsilbi closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant