Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#29 - Fix adding Foreign Key #38

Merged
merged 4 commits into from
Jan 29, 2020
Merged

#29 - Fix adding Foreign Key #38

merged 4 commits into from
Jan 29, 2020

Conversation

Jeckerson
Copy link
Member

Issue - #29

@Jeckerson Jeckerson added bug Something isn't working MySQL labels Jan 29, 2020
@Jeckerson Jeckerson added this to the 1.1.x milestone Jan 29, 2020
@Jeckerson Jeckerson self-assigned this Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #38 into master will increase coverage by 2.19%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage     30.48%   32.67%   +2.19%     
  Complexity      609      609              
============================================
  Files            26       26              
  Lines          1624     1625       +1     
============================================
+ Hits            495      531      +36     
+ Misses         1129     1094      -35
Impacted Files Coverage Δ Complexity Δ
src/Mvc/Model/Migration.php 47.91% <50%> (+8.74%) 168 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b84cec...077c882. Read the comment docs.

@Jeckerson Jeckerson merged commit 9a820f9 into master Jan 29, 2020
@Jeckerson Jeckerson deleted the fix/#29-foreign-key branch January 29, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruudboon ruudboon ruudboon approved these changes

@niden niden Awaiting requested review from niden

@sergeyklay sergeyklay Awaiting requested review from sergeyklay

Assignees

@Jeckerson Jeckerson

Labels
bug Something isn't working MySQL
Projects
Phalcon v5
Archived in project
Milestone
1.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @ruudboon