Added ability to search for resources. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using REST Framework’s SearchFilter, added support for searching for resources. Added docs explaining how to search and the fields on each resources that are searchable. Added basic tests for using the search param.
|
Wow, nice work @msgerbush ! Thanks for this - I'm going to look over it on Monday properly then I'll merge + ship :) |
|
@msgerbush will this require a migration? |
|
Nope, no migration! |
|
💃 |
|
@msgerbush deployed! It works really well |
|
@phalt, great! Thanks and glad to hear it's working well 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #20, I figure it's a little more flexible than the field filtering of
DjangoFilterBackend, which requires exact matches. I added support for the basic 'name' fields on each model, but we can add more, if it makes sense.resources.
that are searchable.