Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to quote array shape keys. Quote characters that aren't whitelisted for array keys. #1664

Closed
TysonAndre opened this issue May 2, 2018 · 1 comment · Fixed by #2675
Closed

Add a way to quote array shape keys. Quote characters that aren't whitelisted for array keys. #1664

TysonAndre opened this issue May 2, 2018 · 1 comment · Fixed by #2675
Assignees
@TysonAndre
Labels
enhancement This improves the quality of Phan's analysis of a codebase

Comments

@TysonAndre
Copy link
Member

E.g. render the array shape type (in issue messages) of [' ' => 'x'] as array{"\x20":string}

TODO: decide on a whitelist.
@TysonAndre TysonAndre added the enhancement This improves the quality of Phan's analysis of a codebase label May 3, 2018
@TysonAndre TysonAndre self-assigned this Mar 29, 2019
@TysonAndre
Copy link
Member Author

Or array{\x20:string} since backslashes aren't allowed, plus other escapes (\u..., \\, \n, etc)

TysonAndre added a commit to TysonAndre/phan that referenced this issue Apr 21, 2019
@TysonAndre
Escape characters in array shape keys
51e5a1c 
Fixes phan#1664
@TysonAndre TysonAndre mentioned this issue Apr 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TysonAndre TysonAndre

Labels
enhancement This improves the quality of Phan's analysis of a codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape characters in array shape keys TysonAndre/phan
1 participant
@TysonAndre