Test fails due to different suggestion text, when nearly all extensions are installed #2041

remicollet · 2018-10-09T07:55:37Z

There were 9 failures:

1) Phan\Tests\PhanTest::testFiles with data set "0058_property_type_check.php" (array('./tests/files/src/0058_proper...ck.php'), './tests/files/expected/0058_p...pected')
Unexpected output in ./tests/files/src/0058_property_type_check.php
Failed asserting that './tests/files/src/0058_property_type_check.php:4 PhanUndeclaredTypeProperty Property \Test::client has undeclared type \Client (Did you mean class \Mosquitto\Client or class \Swoole\Client or class \Swoole\Coroutine\Client or class \Swoole\Coroutine\Http\Client or class \Swoole\Coroutine\Http2\Client or class \Swoole\Http\Client or class \http\Client)\n
./tests/files/src/0058_property_type_check.php:6 PhanUndeclaredTypeParameter Parameter of undeclared type \Client (Did you mean class \Mosquitto\Client or class \Swoole\Client or class \Swoole\Coroutine\Client or class \Swoole\Coroutine\Http\Client or class \Swoole\Coroutine\Http2\Client or class \Swoole\Http\Client or class \http\Client)\n
./tests/files/src/0058_property_type_check.php:8 PhanUndeclaredClassMethod Call to method test from undeclared class \Client (Did you mean class \Mosquitto\Client or class \Swoole\Client or class \Swoole\Coroutine\Client or class \Swoole\Coroutine\Http\Client or class \Swoole\Coroutine\Http2\Client or class \Swoole\Http\Client or class \http\Client)\n
' matches PCRE pattern "/^[^\r\n]+\:4 PhanUndeclaredTypeProperty Property \\Test\:\:client has undeclared type \\Client
[^\r\n]+\:6 PhanUndeclaredTypeParameter Parameter of undeclared type \\Client
[^\r\n]+\:8 PhanUndeclaredClassMethod Call to method test from undeclared class \\Client$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

2) Phan\Tests\PhanTest::testFiles with data set "0241_nullable_71.php" (array('./tests/files/src/0241_nullable_71.php'), './tests/files/expected/0241_n...pected')
Unexpected output in ./tests/files/src/0241_nullable_71.php
Failed asserting that './tests/files/src/0241_nullable_71.php:2 PhanTypeMissingReturn Method \f241_0 is declared to return string but has no return value\n
./tests/files/src/0241_nullable_71.php:4 PhanTypeMismatchReturn Returning type 42 but f241_1() is declared to return ?string\n
./tests/files/src/0241_nullable_71.php:13 PhanTypeMismatchArgument Argument 1 (name) is 42 but \f241_3() takes ?string defined at ./tests/files/src/0241_nullable_71.php:11\n
./tests/files/src/0241_nullable_71.php:26 PhanTypeMismatchReturn Returning type 42 but f241_5() is declared to return ?string\n
./tests/files/src/0241_nullable_71.php:41 PhanTypeMismatchReturn Returning type null but f241_10() is declared to return \Tuple<int,string>\n
./tests/files/src/0241_nullable_71.php:41 PhanUndeclaredTypeReturnType Return type of f241_10 is undeclared type \Tuple<int,string> (Did you mean class \Cassandra\Tuple or class \Cassandra\Type\Tuple)\n
' matches PCRE pattern "/^[^\r\n]+\:2 PhanTypeMissingReturn Method \\f241_0 is declared to return string but has no return value
[^\r\n]+\:4 PhanTypeMismatchReturn Returning type 42 but f241_1\(\) is declared to return \?string
[^\r\n]+\:13 PhanTypeMismatchArgument Argument 1 \(name\) is 42 but \\f241_3\(\) takes \?string defined at [^\r\n]+\:11
[^\r\n]+\:26 PhanTypeMismatchReturn Returning type 42 but f241_5\(\) is declared to return \?string
[^\r\n]+\:41 PhanTypeMismatchReturn Returning type null but f241_10\(\) is declared to return \\Tuple\<int,string\>
[^\r\n]+\:41 PhanUndeclaredTypeReturnType Return type of f241_10 is undeclared type \\Tuple\<int,string\>$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

3) Phan\Tests\PhanTest::testFiles with data set "0263_alias_outside_phpdoc.php" (array('./tests/files/src/0263_alias_...oc.php'), './tests/files/expected/0263_a...pected')
Unexpected output in ./tests/files/src/0263_alias_outside_phpdoc.php
Failed asserting that './tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeParameter Parameter of undeclared type \boolean\n
./tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeParameter Parameter of undeclared type \callback (Did you mean class \Phalcon\Validation\Validator\Callback)\n
./tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeParameter Parameter of undeclared type \double\n
./tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeParameter Parameter of undeclared type \integer\n
./tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeParameter Parameter of undeclared type array<int,\double>\n
./tests/files/src/0263_alias_outside_phpdoc.php:4 PhanUndeclaredTypeReturnType Return type of foo263 is undeclared type \boolean\n
./tests/files/src/0263_alias_outside_phpdoc.php:5 PhanTypeMismatchReturn Returning type false but foo263() is declared to return \boolean\n
./tests/files/src/0263_alias_outside_phpdoc.php:7 PhanTypeMismatchArgument Argument 1 (a) is false but \foo263() takes \boolean defined at ./tests/files/src/0263_alias_outside_phpdoc.php:4\n
./tests/files/src/0263_alias_outside_phpdoc.php:7 PhanTypeMismatchArgument Argument 2 (b) is 2 but \foo263() takes \integer defined at ./tests/files/src/0263_alias_outside_phpdoc.php:4\n
./tests/files/src/0263_alias_outside_phpdoc.php:7 PhanTypeMismatchArgument Argument 3 (c) is Closure():void but \foo263() takes \callback defined at ./tests/files/src/0263_alias_outside_phpdoc.php:4\n
./tests/files/src/0263_alias_outside_phpdoc.php:7 PhanTypeMismatchArgument Argument 4 (d) is float but \foo263() takes \double defined at ./tests/files/src/0263_alias_outside_phpdoc.php:4\n
./tests/files/src/0263_alias_outside_phpdoc.php:7 PhanTypeMismatchArgument Argument 5 (e) is float but \foo263() takes \double defined at ./tests/files/src/0263_alias_outside_phpdoc.php:4\n
' matches PCRE pattern "/^[^\r\n]+\:4 PhanUndeclaredTypeParameter Parameter of undeclared type \\boolean
[^\r\n]+\:4 PhanUndeclaredTypeParameter Parameter of undeclared type \\callback
[^\r\n]+\:4 PhanUndeclaredTypeParameter Parameter of undeclared type \\double
[^\r\n]+\:4 PhanUndeclaredTypeParameter Parameter of undeclared type \\integer
[^\r\n]+\:4 PhanUndeclaredTypeParameter Parameter of undeclared type array\<int,\\double\>
[^\r\n]+\:4 PhanUndeclaredTypeReturnType Return type of foo263 is undeclared type \\boolean
[^\r\n]+\:5 PhanTypeMismatchReturn Returning type false but foo263\(\) is declared to return \\boolean
[^\r\n]+\:7 PhanTypeMismatchArgument Argument 1 \(a\) is false but \\foo263\(\) takes \\boolean defined at [^\r\n]+\:4
[^\r\n]+\:7 PhanTypeMismatchArgument Argument 2 \(b\) is 2 but \\foo263\(\) takes \\integer defined at [^\r\n]+\:4
[^\r\n]+\:7 PhanTypeMismatchArgument Argument 3 \(c\) is Closure\(\)\:void but \\foo263\(\) takes \\callback defined at [^\r\n]+\:4
[^\r\n]+\:7 PhanTypeMismatchArgument Argument 4 \(d\) is float but \\foo263\(\) takes \\double defined at [^\r\n]+\:4
[^\r\n]+\:7 PhanTypeMismatchArgument Argument 5 \(e\) is float but \\foo263\(\) takes \\double defined at [^\r\n]+\:4$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

4) Phan\Tests\PhanTest::testFiles with data set "0289_check_incorrect_soft_types.php" (array('./tests/files/src/0289_check_...es.php'), './tests/files/expected/0289_c...pected')
Unexpected output in ./tests/files/src/0289_check_incorrect_soft_types.php
Failed asserting that './tests/files/src/0289_check_incorrect_soft_types.php:3 PhanUndeclaredTypeParameter Parameter of undeclared type \resource (Did you mean class \Phalcon\Acl\Resource or class \Phalcon\Assets\Resource)\n
./tests/files/src/0289_check_incorrect_soft_types.php:4 PhanTypeMismatchArgumentInternal Argument 1 (fp) is \resource but \fread() takes resource\n
./tests/files/src/0289_check_incorrect_soft_types.php:10 PhanTypeMismatchArgumentInternal Argument 1 (numerator) is false|resource but \intdiv() takes int\n
./tests/files/src/0289_check_incorrect_soft_types.php:14 PhanCompatibleNullableTypePHP71 Type 'object' refers to any object starting in PHP 7.2. In PHP 7.1 and earlier, it refers to a class/interface with the name 'object'\n
./tests/files/src/0289_check_incorrect_soft_types.php:18 PhanUndeclaredTypeParameter Parameter of undeclared type \mixed\n
' matches PCRE pattern "/^[^\r\n]+\:3 PhanUndeclaredTypeParameter Parameter of undeclared type \\resource
[^\r\n]+\:4 PhanTypeMismatchArgumentInternal Argument 1 \(fp\) is \\resource but \\fread\(\) takes resource
[^\r\n]+\:10 PhanTypeMismatchArgumentInternal Argument 1 \(numerator\) is false\|resource but \\intdiv\(\) takes int
[^\r\n]+\:14 PhanCompatibleNullableTypePHP71 Type 'object' refers to any object starting in PHP 7\.2\. In PHP 7\.1 and earlier, it refers to a class\/interface with the name 'object'
[^\r\n]+\:18 PhanUndeclaredTypeParameter Parameter of undeclared type \\mixed$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

5) Phan\Tests\PhanTest::testFiles with data set "0360_undeclared_array_class_in_namespace.php" (array('./tests/files/src/0360_undecl...ce.php'), './tests/files/expected/0360_u...pected')
Unexpected output in ./tests/files/src/0360_undeclared_array_class_in_namespace.php
Failed asserting that './tests/files/src/0360_undeclared_array_class_in_namespace.php:12 PhanUndeclaredTypeParameter Parameter of undeclared type \Foo\Baz\MissingClass[][][]\n
./tests/files/src/0360_undeclared_array_class_in_namespace.php:12 PhanUndeclaredTypeReturnType Return type of myMethod is undeclared type \Foo\Bat\OtherMissingClass[][]\n
./tests/files/src/0360_undeclared_array_class_in_namespace.php:18 PhanUndeclaredTypeProperty Property \Foo\Bar\MyClass::y has undeclared type \Foo\Bar\Closure[][] (Did you mean class \Closure)\n
./tests/files/src/0360_undeclared_array_class_in_namespace.php:22 PhanUndeclaredTypeProperty Property \Foo\Bar\MyClass::str has undeclared type \Foo\Bar\strong (Did you mean class \CommonMark\Node\Text\Strong or string)\n
internal:0 PhanAccessExtendsFinalClassInternal Attempting to extend from final internal class \CommonMark\Node\n
internal:0 PhanAccessWrongInheritanceCategoryInternal Attempting to inherit internal final abstract Class \CommonMark\Interfaces\IVisitable as if it were a Interface\n
' matches PCRE pattern "/^[^\r\n]+\:12 PhanUndeclaredTypeParameter Parameter of undeclared type \\Foo\\Baz\\MissingClass\[\]\[\]\[\]
[^\r\n]+\:12 PhanUndeclaredTypeReturnType Return type of myMethod is undeclared type \\Foo\\Bat\\OtherMissingClass\[\]\[\]
[^\r\n]+\:18 PhanUndeclaredTypeProperty Property \\Foo\\Bar\\MyClass\:\:y has undeclared type \\Foo\\Bar\\Closure\[\]\[\] \(Did you mean class \\Closure\)
[^\r\n]+\:22 PhanUndeclaredTypeProperty Property \\Foo\\Bar\\MyClass\:\:str has undeclared type \\Foo\\Bar\\strong \(Did you mean string\)$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

6) Phan\Tests\PhanTest::testFiles with data set "0478_undeclared_classlike_suggestions.php" (array('./tests/files/src/0478_undecl...ns.php'), './tests/files/expected/0478_u...pected')
Unexpected output in ./tests/files/src/0478_undeclared_classlike_suggestions.php
Failed asserting that './tests/files/src/0478_undeclared_classlike_suggestions.php:4 PhanUndeclaredClassMethod Call to method __construct from undeclared class \past\MyNode (Did you mean class \NS3\MyNode)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:5 PhanUndeclaredClassConstant Reference to constant class from undeclared class \MyNode (Did you mean class \NS3\MyNode)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:7 PhanUndeclaredExtendedClass Class extends undeclared class \ExampleBaseClass (Did you mean class \NS2\ExampleBaseClass)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:7 PhanUndeclaredInterface Class implements undeclared interface \ExampleInterface (Did you mean interface \NS2\ExampleInterface)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:7 PhanUndeclaredTrait Class uses undeclared trait \ExampleTrait (Did you mean trait \NS2\ExampleTrait)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:16 PhanUndeclaredClassConstant Reference to constant class from undeclared class \NS3\ClassWithRepeatedName (Did you mean class \ClassWithRepeatedName or class \NS2\ClassWithRepeatedName)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:23 PhanUndeclaredClassCatch Catching undeclared class \NS2\Exception (Did you mean class \Exception or interface \Cassandra\Exception or class \Couchbase\Exception or interface \Handlebars\Exception or interface \MongoDB\Driver\Exception\Exception or class \Mosquitto\Exception or class \Phalcon\Exception or class \Phalcon\Acl\Exception or class \Phalcon\Annotations\Exception or class \Phalcon\Application\Exception or class \Phalcon\Assets\Exception or class \Phalcon\Cache\Exception or class \Phalcon\Cli\Console\Exception or class \Phalcon\Cli\Dispatcher\Exception or class \Phalcon\Cli\Router\Exception or class \Phalcon\Config\Exception or class \Phalcon\Crypt\Exception or class \Phalcon\Db\Exception or class \Phalcon\Debug\Exception or class \Phalcon\Di\Exception or class \Phalcon\Escaper\Exception or class \Phalcon\Events\Exception or class \Phalcon\Factory\Exception or class \Phalcon\Filter\Exception or class \Phalcon\Flash\Exception or class \Phalcon\Forms\Exception or class \Phalcon\Http\Cookie\Exception or class \Phalcon\Http\Request\Exception or class \Phalcon\Http\Response\Exception or class \Phalcon\Image\Exception or class \Phalcon\Loader\Exception or class \Phalcon\Logger\Exception or class \Phalcon\Mvc\Application\Exception or class \Phalcon\Mvc\Collection\Exception or class \Phalcon\Mvc\Dispatcher\Exception or class \Phalcon\Mvc\Micro\Exception or class \Phalcon\Mvc\Model\Exception or class \Phalcon\Mvc\Model\Transaction\Exception or class \Phalcon\Mvc\Router\Exception or class \Phalcon\Mvc\Url\Exception or class \Phalcon\Mvc\View\Exception or class \Phalcon\Mvc\View\Engine\Volt\Exception or class \Phalcon\Paginator\Exception or class \Phalcon\Queue\Beanstalk\Exception or class \Phalcon\Security\Exception or class \Phalcon\Session\Exception or class \Phalcon\Tag\Exception or class \Phalcon\Translate\Exception or class \Phalcon\Validation\Exception or class \Phalcon\Validation\Validator\Exception or class \RdKafka\Exception or class \Swoole\Exception or class \Swoole\Coroutine\MySQL\Exception or class \Swoole\Coroutine\Socket\Exception or class \Swoole\MySQL\Exception or class \Vtiful\Kernel\Exception or class \XMLDiff\Exception or interface \http\Exception or class \mysql_xdevapi\Exception or interface \pq\Exception)\n
./tests/files/src/0478_undeclared_classlike_suggestions.php:26 PhanUndeclaredClassInstanceof Checking instanceof against undeclared class \NS2\InvalidArgumentException (Did you mean class \InvalidArgumentException or class \Cassandra\Exception\InvalidArgumentException or class \Handlebars\InvalidArgumentException or class \MongoDB\Driver\Exception\InvalidArgumentException or interface \Psr\Cache\InvalidArgumentException or class \Psr\Log\InvalidArgumentException or interface \Psr\SimpleCache\InvalidArgumentException or class \http\Exception\InvalidArgumentException or class \pq\Exception\InvalidArgumentException)\n
' matches PCRE pattern "/^[^\r\n]+\:4 PhanUndeclaredClassMethod Call to method __construct from undeclared class \\past\\MyNode \(Did you mean class \\NS3\\MyNode\)
[^\r\n]+\:5 PhanUndeclaredClassConstant Reference to constant class from undeclared class \\MyNode \(Did you mean class \\NS3\\MyNode\)
[^\r\n]+\:7 PhanUndeclaredExtendedClass Class extends undeclared class \\ExampleBaseClass \(Did you mean class \\NS2\\ExampleBaseClass\)
[^\r\n]+\:7 PhanUndeclaredInterface Class implements undeclared interface \\ExampleInterface \(Did you mean interface \\NS2\\ExampleInterface\)
[^\r\n]+\:7 PhanUndeclaredTrait Class uses undeclared trait \\ExampleTrait \(Did you mean trait \\NS2\\ExampleTrait\)
[^\r\n]+\:16 PhanUndeclaredClassConstant Reference to constant class from undeclared class \\NS3\\ClassWithRepeatedName \(Did you mean class \\ClassWithRepeatedName or class \\NS2\\ClassWithRepeatedName\)
[^\r\n]+\:23 PhanUndeclaredClassCatch Catching undeclared class \\NS2\\Exception \(Did you mean class \\Exception\)
[^\r\n]+\:26 PhanUndeclaredClassInstanceof Checking instanceof against undeclared class \\NS2\\InvalidArgumentException \(Did you mean class \\InvalidArgumentException\)$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

7) Phan\Tests\PhanTest::testFiles with data set "0539_method_param_line_warning.php" (array('./tests/files/src/0539_method...ng.php'), './tests/files/expected/0539_m...pected')
Unexpected output in ./tests/files/src/0539_method_param_line_warning.php
Failed asserting that './tests/files/src/0539_method_param_line_warning.php:31 PhanUndeclaredTypeParameter Parameter of undeclared type \stdClas\n
' matches PCRE pattern "/^[^\r\n]+\:31 PhanUndeclaredTypeParameter Parameter of undeclared type \\stdClas \(Did you mean class \\stdClass\)$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

8) Phan\Tests\RasmusTest::testFiles with data set "0025_catch.php" (array('./tests/rasmus_files/src/0025...ch.php'), './tests/rasmus_files/expected...pected')
Unexpected output in ./tests/rasmus_files/src/0025_catch.php
Failed asserting that './tests/rasmus_files/src/0025_catch.php:4 PhanUndeclaredClassMethod Call to method __construct from undeclared class \Ex\n
./tests/rasmus_files/src/0025_catch.php:5 PhanUndeclaredClassCatch Catching undeclared class \Exceptio\n
./tests/rasmus_files/src/0025_catch.php:6 PhanUndeclaredClassMethod Call to method getMessage from undeclared class \Exceptio\n
' matches PCRE pattern "/^[^\r\n]+\:4 PhanUndeclaredClassMethod Call to method __construct from undeclared class \\Ex
[^\r\n]+\:5 PhanUndeclaredClassCatch Catching undeclared class \\Exceptio \(Did you mean class \\Exception\)
[^\r\n]+\:6 PhanUndeclaredClassMethod Call to method getMessage from undeclared class \\Exceptio \(Did you mean class \\Exception\)$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252

9) Phan\Tests\PHP72Test::testFiles with data set "0001_objecthint.php" (array('./tests/php72_files/src/0001_...nt.php'), './tests/php72_files/expected/...pected')
Unexpected output in ./tests/php72_files/src/0001_objecthint.php
Failed asserting that './tests/php72_files/src/0001_objecthint.php:9 PhanTypeMismatchReturn Returning type null but object_test() is declared to return object\n
./tests/php72_files/src/0001_objecthint.php:13 PhanTypeMismatchArgument Argument 1 (x) is null but \object_test() takes object defined at ./tests/php72_files/src/0001_objecthint.php:3\n
./tests/php72_files/src/0001_objecthint.php:14 PhanTypeMismatchArgument Argument 1 (x) is array{} but \object_test() takes object defined at ./tests/php72_files/src/0001_objecthint.php:3\n
./tests/php72_files/src/0001_objecthint.php:14 PhanTypeMismatchArgument Argument 2 (y) is array{} but \object_test() takes ?object defined at ./tests/php72_files/src/0001_objecthint.php:3\n
./tests/php72_files/src/0001_objecthint.php:26 PhanTypeMismatchReturn Returning type 'invalid' but nullableobject_test() is declared to return ?object\n
./tests/php72_files/src/0001_objecthint.php:29 PhanUndeclaredClassMethod Call to method __construct from undeclared class \object (Did you mean class \WKHTMLTOX\PDF\Object)\n
' matches PCRE pattern "/^[^\r\n]+\:9 PhanTypeMismatchReturn Returning type null but object_test\(\) is declared to return object
[^\r\n]+\:13 PhanTypeMismatchArgument Argument 1 \(x\) is null but \\object_test\(\) takes object defined at [^\r\n]+\:3
[^\r\n]+\:14 PhanTypeMismatchArgument Argument 1 \(x\) is array\{\} but \\object_test\(\) takes object defined at [^\r\n]+\:3
[^\r\n]+\:14 PhanTypeMismatchArgument Argument 2 \(y\) is array\{\} but \\object_test\(\) takes \?object defined at [^\r\n]+\:3
[^\r\n]+\:26 PhanTypeMismatchReturn Returning type 'invalid' but nullableobject_test\(\) is declared to return \?object
[^\r\n]+\:29 PhanUndeclaredClassMethod Call to method __construct from undeclared class \\object$/".

/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/AbstractPhanFileTest.php:252
/dev/shm/BUILD/phan-aba95779b350f8b19a86d498c141bec2e105a556/tests/Phan/PHP72Test.php:56

Some seems related to cassandra 1.3.2, phalcon 3.4.1 , swoole 4.2.1 being enabled during the test suite

The text was updated successfully, but these errors were encountered:

TysonAndre · 2018-10-09T13:54:11Z

(Did you mean class \Mosquitto\Client or class \Swoole\Client or class \Swoole\Coroutine\Client or class \Swoole\Coroutine\Http\Client or class \Swoole\Coroutine\Http2\Client or class \Swoole\Http\Client or class \http\Client) was added because of the additional classes in the modules you've installed.

Using class names that won't have conflicts in different namespaces is one way to fix this.

Additionally, because the global namespace has many more class names (of each allowed string length for a substitute), Phan gave up on checking for selections of certain lengths because of suggestion_check_limit (https://github.com/phan/phan/wiki/Phan-Config-Settings#suggestion_check_limit).
Raising that limit in tests is one way to avoid this.

TysonAndre · 2018-10-09T22:31:58Z

@remicollet - do you have a link to the steps you used to set up that PHP binary?

Also, tests/run_all_tests may reveal more issues

Alternate suggestions may have been generated depending on what PHP modules were installed with the PHP binary used to run the unit tests. - Rename some classes to avoid this ambiguity - Increase the suggestion check limit so that test results will include all suggestions - Add `%S` where suggestions might go (a wildcard with 0 or more characters) For phan#2041

remicollet · 2018-10-10T05:50:39Z

@remicollet - do you have a link to the steps you used to set up that PHP binary?

It is my dev computer

Mostly Fedora 27 (for now) and "dnf install php*"

TysonAndre · 2018-10-21T17:21:46Z

The reported warnings were fixed. Followup issues can be filed if any other issues are seen.

TysonAndre added the tests label Oct 9, 2018

TysonAndre changed the title ~~Test failures when nearly all extensions installed~~ Test fails due to different suggestion text, when nearly all extensions are installed Oct 9, 2018

TysonAndre mentioned this issue Oct 9, 2018

Update tests to account for alternate suggestions #2043

Merged

TysonAndre closed this as completed Oct 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test fails due to different suggestion text, when nearly all extensions are installed #2041

Test fails due to different suggestion text, when nearly all extensions are installed #2041

remicollet commented Oct 9, 2018

TysonAndre commented Oct 9, 2018 •

edited

Loading

TysonAndre commented Oct 9, 2018

remicollet commented Oct 10, 2018

TysonAndre commented Oct 21, 2018

Test fails due to different suggestion text, when nearly all extensions are installed #2041

Test fails due to different suggestion text, when nearly all extensions are installed #2041

Comments

remicollet commented Oct 9, 2018

TysonAndre commented Oct 9, 2018 • edited Loading

TysonAndre commented Oct 9, 2018

remicollet commented Oct 10, 2018

TysonAndre commented Oct 21, 2018

TysonAndre commented Oct 9, 2018 •

edited

Loading