Custom exit/error functions

[bugreportuser]

Sometimes, it's helpful to use a custom function that always exits. Psalm now detects these automatically and allows them to be configured, but I couldn't find the same for Phan.

Example:

<?php
declare(strict_types=1);

function customExit1 () {
    throw new Exception();
}

function customExit2 () {
    trigger_error('msg', E_USER_ERROR);
}

function customExit3 () {
    exit;
}

$val = strpos('a', 'b');
if ($val === false) {
    customExit1();
    customExit2();
    customExit3();
}
var_dump(strlen($val));

Example output:

$ phan exit.php
exit.php:22 PhanTypeMismatchArgumentInternal Argument 1 (string) is false|int but \strlen() takes string

[TysonAndre]

My current thoughts would be to support these checks with global functions and static method invocations (i.e. anything that can be inferred without knowing variable types and added to a more precise BlockExitStatusChecker)

[bugreportuser]

That's reasonable. It should be rare to have dynamic functions that always exit.

[TysonAndre]

The other approach would be to manually set all of the flags at runtime (for instance flags), and recursively invalidate and recompute the flags for parent nodes until they stop changing or the end of the current function scope is reached

[bugreportuser]

Thanks!