Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive PhanUnreferencedPublicProperty (etc.) for internal_stubs folder #2605

Closed
TysonAndre opened this issue Mar 22, 2019 · 0 comments · Fixed by #2674
Closed

False positive PhanUnreferencedPublicProperty (etc.) for internal_stubs folder #2605

TysonAndre opened this issue Mar 22, 2019 · 0 comments · Fixed by #2674
Labels
dead code detection Affects --dead-code-detection enhancement This improves the quality of Phan's analysis of a codebase

Comments

@TysonAndre
Copy link
Member

e.g. internal:23 PhanUnreferencedPublicProperty Possibly zero references to public property \SolrClient->_hashtable_index

These aren't actionable, so they should be omitted.
@TysonAndre TysonAndre added enhancement This improves the quality of Phan's analysis of a codebase dead code detection Affects --dead-code-detection labels Mar 22, 2019
TysonAndre added a commit to TysonAndre/phan that referenced this issue Apr 21, 2019
@TysonAndre
Fix dead code detection false positives for internal stubs
0a3fe46 
Fixes phan#2605
@TysonAndre TysonAndre mentioned this issue Apr 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dead code detection Affects --dead-code-detection enhancement This improves the quality of Phan's analysis of a codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dead code detection false positives for internal stubs TysonAndre/phan
1 participant
@TysonAndre