PHP8 Mixed Type Not Being Detected As Nullable #4277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 30, 2020 21:31
* staging: The Fix Existing test Work Tests
Went with #4278 instead - the changes to properly analyze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this PR should resolve the issue by marking it as
?mixedinternally, but then it should output asmixed(creating valid PHP code where applicable).The above said, I have only worked with the repo itself for a few hours; so there is a high chance I have either missed issues this will cause and/or other affected cases. If that is the case, I am happy to try and fix if feedback is provided :)
This relates to issue 4276. I realise now that the PR might count as an issue (I am more used to Bitbucket where I need to create an issue and a PR). I won't mess further, but I am sorry if I have caused more admin!