mixed should be treated as nullable
#4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Work on fixing the false positives during redundant condition detection - Add a separate `non-null-mixed` type - TODO: Avoid regressions in inferred phpdoc type for array access - TODO: Continue to infer phpdoc `?mixed` type with a `?` in issue messages when combining mixed with null or converting mixed to nullable. (and emit PhanTypeArraySuspiciousNullable) For phan#4276
Update tests and implementation to handle edge cases uncovered by the previous commit.
TysonAndre
force-pushed
the
non-null-mixed
branch
from
b3d7333
to
cd5bdb5
Compare
TysonAndre
changed the title
mixed should be treated as nullablemixed should be treated as nullable
and run phpcbf
TysonAndre
force-pushed
the
non-null-mixed
branch
from
cd5bdb5
to
8c0d79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detection
non-null-mixedtype?mixedtype with a?in issue messageswhen combining mixed with null or converting mixed to nullable.
(and emit PhanTypeArraySuspiciousNullable)
For #4276