Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed should be treated as nullable #4278

Merged
merged 3 commits into from
Dec 7, 2020
Merged

mixed should be treated as nullable #4278

merged 3 commits into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. WIP(broken) - mixed should be treated as nullable 

    - Work on fixing the false positives during redundant condition
  detection
- Add a separate `non-null-mixed` type
- TODO: Avoid regressions in inferred phpdoc type for array access
- TODO: Continue to infer phpdoc `?mixed` type with a `?` in issue messages
  when combining mixed with null or converting mixed to nullable.
  (and emit PhanTypeArraySuspiciousNullable)

For phan#4276
    @TysonAndre
    TysonAndre committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    38beaab View commit details
    Browse the repository at this point in the history

  2. WIP(broken) - Support non-null-mixed 

    Update tests and implementation to handle edge cases uncovered by the
previous commit.
    @TysonAndre
    TysonAndre committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    c18ae5b View commit details
    Browse the repository at this point in the history

  3. Code changes to handle false positives for mixed 

    and run phpcbf
    @TysonAndre
    TysonAndre committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8c0d79b View commit details
    Browse the repository at this point in the history