Adjustment of buffer pixel overrides for better evaluation of MIN_LENGTH for transportation_name #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r applying the limit before merging
msbarry
reviewed
Dec 1, 2023
Comment on lines
115
to
120
| .put(6, 10_000) | ||
| .put(7, 10_000) | ||
| .put(8, 7_000) | ||
| .put(9, 4_000) | ||
| .put(10, 2_000) | ||
| .put(11, 1_000); |
There was a problem hiding this comment.
The logic below actually does apply this min-length filter after the merge. It just needs to set setBufferPixelOverrides before the merge to ensure that when post-processing a tile we have visibility into enough of the line outside the tile bounds.
There was a problem hiding this comment.
OK, the bug seems to be that MIN_LENGTH is used also for setBufferPixelOverrides().
With https://www.openstreetmap.org/way/220348633#map=13/41.5817/-71.3907 as an example, its end near airport is different tile at Z13 and given long name (compared to what is in MIN_LENGTH for Z13) the end gets cut. Hence I've added BUFFER_PIXEL_OVERRIDES with 256 px (e.g. "while tile"):
Is that OK? Is there a simpler way?
…lanetiler applying the limit before merging" This reverts commit 8fb6707.
Make sure we have enough room (=whole next tile) when checking MIN_LENGTH,
to avoid pieces of otherwise "long enough" lines to be excluded (thus
creating "holes" or missing ends) in some tiles just because length in that
particular tile is bellow limit. Given that MIN_LENGTH values translated to
pixels are quite big (compared to {@code BUFFER_SIZE}), such missing pieces
would be quite noticeable.
This improves items mainly in Z12-Z13.
phanecak-maptiler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: This PR increases buffer pixel overrides so as to allow proper evaluation of (unchanged)
MIN_LENGTHfor lines which cross tiles.older description (= "how it started"), which no longer matches the PR (= "how it's going"):
This PR adjusts
MIN_LENGTHfortransportation_nameto 1/2 of values used in OpenMapTiles, to partially counter the effect of Planetiler applying the limit before merging (while OpenMapTiles is applying the limit after merging).What is produced by OpenMapTiles/master: Rhode Island, Z9
What is produced by
phanecak-maptiler/planetiler-openmaptiles/omt_3_15_0:And what is produced with adjustments in this PR:
Example of filtering:
Note: Difference was observed while porting openmaptiles/openmaptiles#1579 , hence same area used in screenshots here.