Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustment of buffer pixel overrides for better evaluation of MIN_LENGTH for transportation_name #28

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Adjustment of buffer pixel overrides for better evaluation of MIN_LENGTH for transportation_name #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fb6707
MIN_LENGTH value halved, to partially counter the effect of Planetile…
phanecak-maptiler Nov 28, 2023
c3239ad
Revert "MIN_LENGTH value halved, to partially counter the effect of P…
phanecak-maptiler Dec 11, 2023
8d26841
use 256px as buffer pixel override instead of MIN_LENGTH
phanecak-maptiler Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/main/java/org/openmaptiles/layers/TransportationName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ public class TransportationName implements
.put(9, 8_000)
.put(10, 4_000)
.put(11, 2_000);
private static final ZoomFunction<Number> BUFFER_PIXEL_OVERRIDES =
ZoomFunction.fromMaxZoomThresholds(Map.of(
13, 256,
6, 256
));
private final boolean brunnel;
private final boolean sizeForShield;
private final boolean limitMerge;
Expand Down Expand Up @@ -255,7 +260,7 @@ public void process(Tables.OsmHighwayLinestring element, FeatureCollector featur

FeatureCollector.Feature feature = features.line(LAYER_NAME)
.setBufferPixels(BUFFER_SIZE)
.setBufferPixelOverrides(MIN_LENGTH)
.setBufferPixelOverrides(BUFFER_PIXEL_OVERRIDES)
// TODO abbreviate road names - can't port osml10n because it is AGPL
.putAttrs(OmtLanguageUtils.getNames(element.source().tags(), translations))
.setAttr(Fields.REF, ref)
Expand Down Expand Up @@ -308,7 +313,7 @@ public void process(Tables.OsmAerialwayLinestring element, FeatureCollector feat
if (!nullOrEmpty(element.name())) {
features.line(LAYER_NAME)
.setBufferPixels(BUFFER_SIZE)
.setBufferPixelOverrides(MIN_LENGTH)
.setBufferPixelOverrides(BUFFER_PIXEL_OVERRIDES)
.putAttrs(OmtLanguageUtils.getNames(element.source().tags(), translations))
.setAttr(Fields.CLASS, "aerialway")
.setAttr(Fields.SUBCLASS, element.aerialway())
Expand All @@ -323,7 +328,7 @@ public void process(Tables.OsmShipwayLinestring element, FeatureCollector featur
if (!nullOrEmpty(element.name())) {
features.line(LAYER_NAME)
.setBufferPixels(BUFFER_SIZE)
.setBufferPixelOverrides(MIN_LENGTH)
.setBufferPixelOverrides(BUFFER_PIXEL_OVERRIDES)
.putAttrs(OmtLanguageUtils.getNames(element.source().tags(), translations))
.setAttr(Fields.CLASS, element.shipway())
.setMinPixelSize(0)
Expand Down