Keep original name for keyword argument

[splhack]

I'm not sure whether there is a reason or not, but with this small example

@m.circuit.combinational
def test(a: m.Bit) -> m.Bit:
  return ~a

the argument name turns into with _0 suffix, after recent ssa change.

class test(m.Circuit):
    IO = ['a_0', m.In(m.Bit), 'O', m.Out(m.Bit)]

I assume I can use positional argument to call the combinational logic like this.

b = test(io.a)

and also keyword argument like this.

b = test(a=io.a)

but this keyword argument doesn't work due to _0 suffix. I needed to change it into test(a_0=io.a).

[coveralls]

Pull Request Test Coverage Report for Build 1496

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 73.533%

---

Totals
Change from base Build 1493:	0.02%
Covered Lines:	3834
Relevant Lines:	5214

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1497

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 73.533%

---

Totals
Change from base Build 1493:	0.02%
Covered Lines:	3834
Relevant Lines:	5214

---

💛 - Coveralls

[leonardt]

The reason for this change was that it was the most elegant solution to handle the case where a variable in the definition matched a variable in the argument list.

There's two ways to address this issue: One is to update the ssa algorithm to appropriately handle inputs. The other is to have circuit.combinational "wrap" the generated ssa circuit with the original port names wired up to the ssa'ed port. The second version is an easier fix that addresses this issue (at the cost of one extra "wrapper" layer introduced in the generated code, I will work on it.

[splhack]

fixed by #361