Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix issue with circuit.combinitational renaming inputs ports #361

Merged
merged 6 commits into from Feb 25, 2019

Conversation

leonardt
Copy link
Collaborator

Addresses the issue in #359 by using the renamed_ports class attribute to map the original port names to the ssa'ed port names

@leonardt
Copy link
Collaborator Author

@splhack when you get a chance, can you try the fix on this branch? The circuit definition generated now has the original names, but this doesn't change the ssa algorithm so it should still properly handle the case when an input name matches a variable name in the body.

@coveralls
Copy link

coveralls commented Feb 22, 2019

Pull Request Test Coverage Report for Build 1511

  • 16 of 19 (84.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 73.523%

Changes Missing Coverage Covered Lines Changed/Added Lines %
magma/syntax/combinational.py 11 14 78.57%
Totals Coverage Status
Change from base Build 1498: 0.005%
Covered Lines: 3832
Relevant Lines: 5212

💛 - Coveralls

@splhack
Copy link
Contributor

splhack commented Feb 23, 2019

confirmed this fixed the issue. thank you for working on this quickly!

@leonardt leonardt merged commit 2f067ff into master Feb 25, 2019
@leonardt leonardt deleted the hotfix-combination-renamed-ports branch February 25, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants