Bug: derive_vars_joined(): *.join variables are included if new_vars = NULL

[bundfussr]

What happened?

• If derive_vars_joined() is called with new_vars = NULL the *.join variables are included in the output dataset.
• Wrong warnings are issued in some cases (see example below).

Session Information

No response

Reproducible Example

myd <- data.frame(day = c(1, 2, 3), val = c(0, 17, 21))
derive_vars_joined(
  myd,
  dataset_add = myd,
  order = exprs(day),
  mode = "last",
  filter_join = day < day.join
)

produces

  day val day.join val.join
1   1   0        3       21
2   2  17        3       21
3   3  21       NA       NA

It should produce an error because day and val from dataset_add are already in dataset.

library(lubridate)
library(dplyr)
adlb_ast <- tribble(
  ~ADT,         ~ASEQ,
  "2002-01-01", 1,
  "2002-02-02", 2,
  "2002-02-02", 3
) %>%
  mutate(
    STUDYID = "ABC",
    USUBJID = "1",
    ADT = ymd(ADT),
    ADTM = as_datetime(ADT)
  )

adlb_tbili_pbl <- tribble(
  ~ADT,         ~ASEQ,
  "2002-01-01", 4,
  "2002-02-02", 5,
  "2002-02-02", 6
) %>%
  mutate(
    STUDYID = "ABC",
    USUBJID = "1",
    ADT = ymd(ADT),
    ADTM = as_datetime(ADT)
  )

derive_vars_joined(
  adlb_ast,
  dataset_add = adlb_tbili_pbl,
  by_vars = exprs(STUDYID, USUBJID),
  order = exprs(ADTM, ASEQ),
  new_vars = exprs(TBILI_ADT = ADT),
  filter_join = ADT <= ADT.join,
  mode = "first"
)

produces

# A tibble: 3 × 6
  ADT         ASEQ STUDYID USUBJID ADTM                TBILI_ADT 
  <date>     <dbl> <chr>   <chr>   <dttm>              <date>    
1 2002-01-01     1 ABC     1       2002-01-01 00:00:00 2002-01-01
2 2002-02-02     2 ABC     1       2002-02-02 00:00:00 2002-02-02
3 2002-02-02     3 ABC     1       2002-02-02 00:00:00 2002-02-02
Warning message:
Dataset contains duplicate records with respect to `STUDYID`, `USUBJID`, `tmp_obs_nr_1`, `ADTM` and `ASEQ`
Run `get_duplicates_dataset()` to access the duplicate records 

[bms63]

@pharmaverse/admiral any takers for this bug fix? WE want to get this hotfix out soon with a couple of other minor updates.

[zdz2101]

Reopening because not fully finished, but some steps were taken in #1987