create a functional workflow for ADEG and assess needed functionality (8h) #264

koegerr · 2021-06-22T11:54:23Z

goal: come up with needed functions to create ADEG dataset and create the required cards on the board

get specs from GSK and Roche
create ADEG workflow
identify any new functions to be created

kabis-ops · 2021-06-29T08:51:19Z

Hi @millerg23
While waiting for the GSK spec, I had a look to the ADVS workflow and the Roche ADEG spec - i think the only addition for ADEG would be AVALCAT1/CHGCAT1?
I have added the draft workflow in Box. Please have a look and let me know what you think :) we can discuss later if needed when we have the GSK spec.

* feat: #1974 try swapping all deprecated assertions * chore: #1974 fix parsing issue that caused vignettes to crash * chore: #1974 simplify by_vars requirement Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> * chore: #264 move assertion to different line --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com>

@Keywords

* Closes #1950 following deprecation process, update Description version and news.md * updating documentation to fix the warnings * added the new tests for minutes and seconds options * Removing references in deprecated functions. * updated comments and applied test_that format * conflicts resolved * Closes #1941 authors contributors@devel (#1967) * Initial edit to `_pkgdown.yml` for #1941 * #1941 re-labelling authors and contributors * #1941 update to enact decision of team regarding who are authors and contributors. * #1941: Chore (spellcheck and man pages and NEWS.md update) * #1941 chore: further updates to spellcheck * #1941: chore: fix space after commas. move some acknowledgees to contributors. link README in authors page. * #1941 chore: roxygenize --------- Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> * Closes #1228 produce bmi records for more visits (#1957) * feat: #1228 Produce BMI records for more visits: Add constant_height parameter * feat: #1228 Produce BMI records for more visits: Update to use constant_by_vars as switch and update examples with more detail. * docs: #1228 Produce BMI records for more visits: Fix typo in NEWS * feat: #1228 Produce BMI records for more visits: Update ADVS template and vignette. * doc: #1228 Produce BMI records for more visits: Add backticks to variable. --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1695 Establish codeowners (#1973) feat: #1695 add gordon and jeff as codeowners Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> * Closes #1974 Swapping out deprecated assertions (#1975) * feat: #1974 try swapping all deprecated assertions * chore: #1974 fix parsing issue that caused vignettes to crash * chore: #1974 simplify by_vars requirement Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> * chore: #264 move assertion to different line --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#1986) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Catch devel up to Admiral v0.11.1 (#1997) (#1999) Admiral v0.11.1 (#1997) * [actions skip] Add/Update README.md for patch * Closes #1962 #1969 admiral 0.11.1 hotfix for get started link, derive_param_tte, derive_vars_joined (#1987) * feat #1962 #1969 param_tte and get started fix * forgot to add updated DESCRIPTION * chore: #1962 thought crossing was dplyr * chore: #1962 account for new assertions * fix: #1962 was missing the reassignment piece? * fix: #1966 crude answer * feat: #1966 potential way of warning users of null new_vars * fix: #1966 add appropriate assertions to get check to go through * fix: #1966 appropriate function fix for order * fix: #1966 vignette named order expression * chore: #1966 try something * chore: #1966 optionality of expressions is tricky * feat: #1966 undo derive_joined stuff * chore: run styler --------- --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Initiate a Stale bot for Issue Triaging (#1992) * Create stale_bot.yml * Update and rename stale_bot.yml to stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Closes #1927 derive param tte@devel (#2000) Removed incorrect reference of start_imputation_flag Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1989 Link Fix in `README.md` (#1994) * Update README.md * Update WORDLIST * Update README.md * Update WORDLIST * chore: #1989 spelling --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1856 Removed the higher order file (#2008) #1856 Removed the higher order file * Update templates.yml (#2026) * Closes #2001 Added processing for missing age_units in `compute_age_years` (#2009) * #2001 added processing for missing age_units in `compute_age_years` * #2001 Chore: styler * #2001 chore: lint * #2001 chore: fix broken links * #2001 - removed for loop, changed unit in `derive_vars_aage`, restored `docs/pkgdown.yml`. * #2001 chore: Fixed docs link * #2001 chore: styler * #2001 implemented prop[er deprecation strategy for `age_unit` in `derive_vars_aage` and added extra test for `age_unit` * #2001 Update NEWS.md as per suggestiom Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update R/compute_age_years.R with correct backquoting Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #2001 version change in deprecation * #2001 insert parenthesis in NEWS.md Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * #2001 chore: roxygen --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1979 Add a flag_all function argument to enhance `derive_var_extreme_flag()` (#2024) * feat: #1979 added the necessary flag_all function argument * feat: #1979 modify check_type to supppress warnings for flag_all = TRUE * chore: #1979 run lintr/styler * chore: #1979 add news blurb * typo * chore: #1979 add additional tests and add roxygen details * chore: #1979 adopt feedback from review * chore: #1979 run styler --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #123 Add Edoardo to status check (#2031) fix: pharmaverse/admiralci#123 add Edoardo to status check * Closes #2014 derive_var_shift change na_val@devel (#2032) * #2014 `na_val` deprecated and `missing_value` inserted into `derive_var_shift`. * #2014 - Update `NEWS.md`. * #2014 - update tests and write deprecation parameter test * #2014 - run required tasks for PR --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2012_derive_vars_dy (#2013) * derive dy_vars by argument .name in across (#2012) use named vector to avoid the variabes end with `_temp` in input dataset * test no error for variable end with `_temp`(#2012) * styled file * add update information for #2012 --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> * Closes #1966 address derive_vars_joined bugs (#2016) * feat: #1966 make our check_type consistent * feat: #1966 hacky solution to null new_vars .join problem * chore: #1966 inserted line in wrong place * feat: #1966 add news blurb for what was done * feat: #1966 add tests * chore: #1966 lintr * chore: #1966 swap appropriate order selection and restore check_type arg * chore: #1966 looks like that fixed it * feat: #1966 issue warning for dataset_add naming conflicts when `new_vars` is NULL * chore: #1966 clean up for readability * chore: #1966 restore original replace_values_by_names * chore: #1966 add additional test to demonstrate how order vars were fixed/selected * feat: #1966 adopt feedback for error messaging of naming conflicts --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2037 deprecate `dataset_expected_obs` for `dataset_ref` in respective functions (#2039) feat: #2037 deprecate `dataset_expected_obs` for `dataset_ref` Co-authored-by: Zelos Zhu <zdz2101@github.com> * Close #1940 Removing unnecessary runtime development-related dependencies (#1978) * feat: #1940 try removing dev deps * chore: #1940 still needs knitr * #1940 diffdf needed for all the testing stuff * chore: #1940 add back rmarkdown Co-authored-by: Adam Foryś <adam.forys@roche.com> --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #1984 Allowing missing trt end date in `derive_var_ontrtfl()` (#2029) * #1984 allowing missing trt end date * Update derive_var_ontrtfl.R * Update derive_var_ontrtfl.R * Increment version number to 0.12.0.9000 * updating version numbers...oops! * Update test-derive_var_ontrtfl.R * Closes #1984 Addressing missing treatment start dates in `derive_var_ontrtfl()` (#2048) addressing missing treatment start dates * Propagate renv.lock from pharmaverse/admiralci (#2046) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * Update .Rbuildignore * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #2033 `derive_var_ontrtfl(span_period)` arg updated to accept T/F (#2044) * span_period arg update * Update derive_var_ontrtfl.R * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * remove space for lintr --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * add admiral src to test codespaces * Revert "add admiral src to test codespaces" This reverts commit 4a60be0. * Propagate renv.lock from pharmaverse/admiralci (#2058) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #2020 chore: rename wt to weight in compute_egfr (#2045) * code updated * Chore #2020 go through checklist * update .lycheeignore * update .lycheeignore * adjusted templates * chore: removed links from .lycheeignore * chore: #2020 removing file --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2053 Typo in the example `impute_dtc_dt` (#2056) Closes #2053 Typo in the example impute_dtc_dt * update `impute_dtc_dtm` to `impute_dtc_dt` in derive_date_vars.R * update derive_date_vars.Rd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2038 Attach See also to compute functions (#2062) Doc: #2038 Attach See also to compute functions Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> * Closes #2042 fix compute_dtf bug (#2047) * feat: #2042 needs to incorporate date portion and location of the double hyphen to parse out correctly * feat: #2042 add appropriate logic for date-portions * chore: #2042 add news * feat: #2042 address month and day missing * feat: #2042 allow - for "Y" flag --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1968 compute multiple variables in `derive_param_computed()` (#2036) * #1968 compute_multiple_vars: update arguments of derive_param_computed() * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: style files * #1968 compute_multiple_vars: fix R-CMD checks * #1968 compute_multiple_vars: update error message of get_hori_data() * #1968 compute_multiple_vars: improve documentation * #1968 compute_multiple_vars: use deprecation badge * #1968 compute_multiple_vars: use deprecation badge * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1968 compute_multiple_vars: use @Keywords internal * #1968 compute_multiple_vars: fix typo in NEWS.md --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1466 Unit test for `print.duplicates()` which closes test coverage gap (#2055) * feat: #2054 remove print.duplciates() * feat: #1466 add appropriate test for print.duplicates * chore: #1466 cleanup duplicate code * feat: #1466 use expect_snapshot() instead --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2040 Update admiral.test to pharmaversesdtm (#2057) * Chore: #2040 Update admiral.test to pharmaversesdtm * Chore: #2040 Update admiraltest to pharmaversesdtm: Update WORDLIST and run styler * #2040 Update admiral.test to pharmaversesdtm: udpate staged_dependencies.yaml * Chore: #2040 Update admiral.test to pharmaversesdtm: rename suppae and admiral_eg. * Chore #2040 Update admiral.test to pharmaversesdtm: Update test-call_derivation.R * Chore: #2040 Update admiral.test to pharmaversesdtm: Update create_query_data.R * Chore: #2040 Update admiral.test to pharmaversesdtm run documentation for create_query_data --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#2064) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * #2027 clarify reference_date in derive_vars_dy() (#2063) * change description * updated news.md * closes #2069 bug: EOSSTT derivation fix (#2073) #2069 bug: EOSSTT derivation fix Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2049 Date/Time Imputation Utilities are no Longer listed on pkgdown site (#2076) * utils_impute fns now internal * Update NEWS.md * adding meta.R entry back * Closes #1875 duration and interval time difference types update (#2075) * in progress * updated default to duration instead of interval * style * spelling updates * Update NEWS.md * added pharmaversesdtm Remotes call * Update DESCRIPTION * Update test-compute_duration.R --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2078 swap out admiral_eg with eg (#2080) feat: #2078 swap out admiral_eg with eg Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1960 enhance derive_extreme_event() (#2015) * #1960 enhance_derive_extreme_event: start a draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: add tests and documentation * #1960 enhance_derive_extreme_event: update NEWS * #1960 enhance_derive_extreme_event: fix links * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event: add example * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event:add example and tests for event-specific modes * #1960 enhance_derive_extreme_event: add ignore_event_order argument * #1960 enhance_derive_extreme_event: fix spelling * #1960 enhance_derive_extreme_event: use correct input dataset * #1960 enhance_derive_extreme_event: improve printing of event objects * #1960 enhance_derive_extreme_event: rename keep_vars_source to keep_source_vars * #1960 enhance_derive_extreme_event: add description field * #1960 enhance_derive_extreme_event: address QC comments * #1960 enhance_derive_extreme_event: update man pages * #1960 enhance_derive_extreme_event: remove docs/pkgdown.yml * #1960 enhance_derive_extreme_event: style files * chore: #1960 properly formatted testthat * chore: #1960 fix lint --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2068 Updated `traceability_vars` to `set_values_to` (#2079) * Closes #2068 Updated `traceability_vars` to `set_values_to` * Clarify the explanation for the traceability_vars replacement * Closes #2083 bug adpp and adpc still using admiraltest (#2086) * fix: #2083 using pharmaversesdtm * fix: #2083 using pharmaversesdtm * chore: #2083 renaming datasets * chore: #2083 removing admiral prefix * chore: #2083 removing admiral suffix * chore: #2083 remove admiral suffix * chore: remove admiral prefix * Closes #1859 metadata updated for DAIDs in xlsx file (#2060) * 1859 metadata updated for DAIDs in xlsx file * 1859 metadata for DAIDs finalised * 1859 update data.r for atoxgr_criteria_daids * 1859 update man files * 1859 fix spelling * 1859 updated derive_var_atoxgr to read in DAIDS and create unit tests * 1859 update man pages * 1859 fix STYLER issue * 1859 fix SPELLING * 1859 fix LINTR * 1859 Fix LINTR and add more unit tests * 1859 added Acidosis and Alkalosis and more unit tests * 1859 added more tests and partiallyy update gradin vignette * 1859 all unit tests added * 1859 fix STYLER * 1859 use signif function in metadata * 1859 use signif function in ncictcaev4 and v5 metadata * Update unit test for Cal (Ionized) to test missing ANRHI Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix unit test for Cal (Ionized) Low for missing ANRLO. Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add units to description of Glucose Nonfasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add unit to description of Glucose fasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix typo in description of Triglycerides, Fasting, High for Grade 3 Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * 1859 address last QC comments on unit tests * 1859 update NEWS file * 1859 updated Vignette * 1859 Fix SPELLING * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 address QC comments * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 Fix STYLER issue * 1859 Fix example in function header * 1859 fix LINTR issue --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2050 Remove print fns from pkgdown Reference page (#2087) ref page updates * Closes #1697 add keep_source_vars arg@devel (#2070) * #1697 Added `keep_vars_source` arg in `derive_extreme_records()`, added relevent unit tests and updated NEWS.md. * Updated pkgdown.yml * Undoing renv.lock update * #1697 Updated default from `NULL` to `exprs(everything())` * #1697 Updated wordlist to include 'tidyselect' * #1697 Moved `select()` after `process_set_values_to()` * #1697 Updated `keep_vars_source` to `keep_source_vars` in `derive_extreme_records()` * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_extreme_records.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1697 Reverted changes made to `derive_var_merged_exist_flag()` and updated `derive_extreme_records()` * #1697 Updated 'Details' section to include `keep_source_vars` --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. (#2082) * #1995 Update to add Sophie as Autor and Stefan's R in Pharma presentation. * #1995 Chore: roxygen * #1995 chore:spellcheck and roxygen * #1995 updates to readme with release schedule and 1.0. * grammar fix in readme --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2028 removed erroneous section. updating rules section (#2088) * docs: #2028 removed erroneous section. updating rules section * docs: #2028 news and wordsmithing * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * docs: #2028 lite explanation of h.i. rule --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2091 fixing deprecation messaging in `derive_param_doseint()` (#2092) * feat: #2091 did that work? * chore: #2091 address errors * fixed deprecation warning * deprecation for analysis_var --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> * Fix for Get Started on Webpage (#2093) Update _pkgdown.yml * update readme with admiral release schedule (#2095) Co-authored-by: Zelos Zhu <zdz2101@github.com> --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com>

@Keywords

* admiral v0.12.0 (#2094) * Closes #1950 following deprecation process, update Description version and news.md * updating documentation to fix the warnings * added the new tests for minutes and seconds options * Removing references in deprecated functions. * updated comments and applied test_that format * conflicts resolved * Closes #1941 authors contributors@devel (#1967) * Initial edit to `_pkgdown.yml` for #1941 * #1941 re-labelling authors and contributors * #1941 update to enact decision of team regarding who are authors and contributors. * #1941: Chore (spellcheck and man pages and NEWS.md update) * #1941 chore: further updates to spellcheck * #1941: chore: fix space after commas. move some acknowledgees to contributors. link README in authors page. * #1941 chore: roxygenize --------- Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> * Closes #1228 produce bmi records for more visits (#1957) * feat: #1228 Produce BMI records for more visits: Add constant_height parameter * feat: #1228 Produce BMI records for more visits: Update to use constant_by_vars as switch and update examples with more detail. * docs: #1228 Produce BMI records for more visits: Fix typo in NEWS * feat: #1228 Produce BMI records for more visits: Update ADVS template and vignette. * doc: #1228 Produce BMI records for more visits: Add backticks to variable. --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1695 Establish codeowners (#1973) feat: #1695 add gordon and jeff as codeowners Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> * Closes #1974 Swapping out deprecated assertions (#1975) * feat: #1974 try swapping all deprecated assertions * chore: #1974 fix parsing issue that caused vignettes to crash * chore: #1974 simplify by_vars requirement Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> * chore: #264 move assertion to different line --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#1986) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Catch devel up to Admiral v0.11.1 (#1997) (#1999) Admiral v0.11.1 (#1997) * [actions skip] Add/Update README.md for patch * Closes #1962 #1969 admiral 0.11.1 hotfix for get started link, derive_param_tte, derive_vars_joined (#1987) * feat #1962 #1969 param_tte and get started fix * forgot to add updated DESCRIPTION * chore: #1962 thought crossing was dplyr * chore: #1962 account for new assertions * fix: #1962 was missing the reassignment piece? * fix: #1966 crude answer * feat: #1966 potential way of warning users of null new_vars * fix: #1966 add appropriate assertions to get check to go through * fix: #1966 appropriate function fix for order * fix: #1966 vignette named order expression * chore: #1966 try something * chore: #1966 optionality of expressions is tricky * feat: #1966 undo derive_joined stuff * chore: run styler --------- --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Initiate a Stale bot for Issue Triaging (#1992) * Create stale_bot.yml * Update and rename stale_bot.yml to stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Closes #1927 derive param tte@devel (#2000) Removed incorrect reference of start_imputation_flag Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1989 Link Fix in `README.md` (#1994) * Update README.md * Update WORDLIST * Update README.md * Update WORDLIST * chore: #1989 spelling --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1856 Removed the higher order file (#2008) #1856 Removed the higher order file * Update templates.yml (#2026) * Closes #2001 Added processing for missing age_units in `compute_age_years` (#2009) * #2001 added processing for missing age_units in `compute_age_years` * #2001 Chore: styler * #2001 chore: lint * #2001 chore: fix broken links * #2001 - removed for loop, changed unit in `derive_vars_aage`, restored `docs/pkgdown.yml`. * #2001 chore: Fixed docs link * #2001 chore: styler * #2001 implemented prop[er deprecation strategy for `age_unit` in `derive_vars_aage` and added extra test for `age_unit` * #2001 Update NEWS.md as per suggestiom Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update R/compute_age_years.R with correct backquoting Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #2001 version change in deprecation * #2001 insert parenthesis in NEWS.md Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * #2001 chore: roxygen --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1979 Add a flag_all function argument to enhance `derive_var_extreme_flag()` (#2024) * feat: #1979 added the necessary flag_all function argument * feat: #1979 modify check_type to supppress warnings for flag_all = TRUE * chore: #1979 run lintr/styler * chore: #1979 add news blurb * typo * chore: #1979 add additional tests and add roxygen details * chore: #1979 adopt feedback from review * chore: #1979 run styler --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #123 Add Edoardo to status check (#2031) fix: pharmaverse/admiralci#123 add Edoardo to status check * Closes #2014 derive_var_shift change na_val@devel (#2032) * #2014 `na_val` deprecated and `missing_value` inserted into `derive_var_shift`. * #2014 - Update `NEWS.md`. * #2014 - update tests and write deprecation parameter test * #2014 - run required tasks for PR --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2012_derive_vars_dy (#2013) * derive dy_vars by argument .name in across (#2012) use named vector to avoid the variabes end with `_temp` in input dataset * test no error for variable end with `_temp`(#2012) * styled file * add update information for #2012 --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> * Closes #1966 address derive_vars_joined bugs (#2016) * feat: #1966 make our check_type consistent * feat: #1966 hacky solution to null new_vars .join problem * chore: #1966 inserted line in wrong place * feat: #1966 add news blurb for what was done * feat: #1966 add tests * chore: #1966 lintr * chore: #1966 swap appropriate order selection and restore check_type arg * chore: #1966 looks like that fixed it * feat: #1966 issue warning for dataset_add naming conflicts when `new_vars` is NULL * chore: #1966 clean up for readability * chore: #1966 restore original replace_values_by_names * chore: #1966 add additional test to demonstrate how order vars were fixed/selected * feat: #1966 adopt feedback for error messaging of naming conflicts --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2037 deprecate `dataset_expected_obs` for `dataset_ref` in respective functions (#2039) feat: #2037 deprecate `dataset_expected_obs` for `dataset_ref` Co-authored-by: Zelos Zhu <zdz2101@github.com> * Close #1940 Removing unnecessary runtime development-related dependencies (#1978) * feat: #1940 try removing dev deps * chore: #1940 still needs knitr * #1940 diffdf needed for all the testing stuff * chore: #1940 add back rmarkdown Co-authored-by: Adam Foryś <adam.forys@roche.com> --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #1984 Allowing missing trt end date in `derive_var_ontrtfl()` (#2029) * #1984 allowing missing trt end date * Update derive_var_ontrtfl.R * Update derive_var_ontrtfl.R * Increment version number to 0.12.0.9000 * updating version numbers...oops! * Update test-derive_var_ontrtfl.R * Closes #1984 Addressing missing treatment start dates in `derive_var_ontrtfl()` (#2048) addressing missing treatment start dates * Propagate renv.lock from pharmaverse/admiralci (#2046) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * Update .Rbuildignore * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #2033 `derive_var_ontrtfl(span_period)` arg updated to accept T/F (#2044) * span_period arg update * Update derive_var_ontrtfl.R * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * remove space for lintr --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * add admiral src to test codespaces * Revert "add admiral src to test codespaces" This reverts commit 4a60be0. * Propagate renv.lock from pharmaverse/admiralci (#2058) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #2020 chore: rename wt to weight in compute_egfr (#2045) * code updated * Chore #2020 go through checklist * update .lycheeignore * update .lycheeignore * adjusted templates * chore: removed links from .lycheeignore * chore: #2020 removing file --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2053 Typo in the example `impute_dtc_dt` (#2056) Closes #2053 Typo in the example impute_dtc_dt * update `impute_dtc_dtm` to `impute_dtc_dt` in derive_date_vars.R * update derive_date_vars.Rd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2038 Attach See also to compute functions (#2062) Doc: #2038 Attach See also to compute functions Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> * Closes #2042 fix compute_dtf bug (#2047) * feat: #2042 needs to incorporate date portion and location of the double hyphen to parse out correctly * feat: #2042 add appropriate logic for date-portions * chore: #2042 add news * feat: #2042 address month and day missing * feat: #2042 allow - for "Y" flag --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1968 compute multiple variables in `derive_param_computed()` (#2036) * #1968 compute_multiple_vars: update arguments of derive_param_computed() * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: style files * #1968 compute_multiple_vars: fix R-CMD checks * #1968 compute_multiple_vars: update error message of get_hori_data() * #1968 compute_multiple_vars: improve documentation * #1968 compute_multiple_vars: use deprecation badge * #1968 compute_multiple_vars: use deprecation badge * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1968 compute_multiple_vars: use @Keywords internal * #1968 compute_multiple_vars: fix typo in NEWS.md --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1466 Unit test for `print.duplicates()` which closes test coverage gap (#2055) * feat: #2054 remove print.duplciates() * feat: #1466 add appropriate test for print.duplicates * chore: #1466 cleanup duplicate code * feat: #1466 use expect_snapshot() instead --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2040 Update admiral.test to pharmaversesdtm (#2057) * Chore: #2040 Update admiral.test to pharmaversesdtm * Chore: #2040 Update admiraltest to pharmaversesdtm: Update WORDLIST and run styler * #2040 Update admiral.test to pharmaversesdtm: udpate staged_dependencies.yaml * Chore: #2040 Update admiral.test to pharmaversesdtm: rename suppae and admiral_eg. * Chore #2040 Update admiral.test to pharmaversesdtm: Update test-call_derivation.R * Chore: #2040 Update admiral.test to pharmaversesdtm: Update create_query_data.R * Chore: #2040 Update admiral.test to pharmaversesdtm run documentation for create_query_data --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#2064) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * #2027 clarify reference_date in derive_vars_dy() (#2063) * change description * updated news.md * closes #2069 bug: EOSSTT derivation fix (#2073) #2069 bug: EOSSTT derivation fix Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2049 Date/Time Imputation Utilities are no Longer listed on pkgdown site (#2076) * utils_impute fns now internal * Update NEWS.md * adding meta.R entry back * Closes #1875 duration and interval time difference types update (#2075) * in progress * updated default to duration instead of interval * style * spelling updates * Update NEWS.md * added pharmaversesdtm Remotes call * Update DESCRIPTION * Update test-compute_duration.R --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2078 swap out admiral_eg with eg (#2080) feat: #2078 swap out admiral_eg with eg Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1960 enhance derive_extreme_event() (#2015) * #1960 enhance_derive_extreme_event: start a draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: add tests and documentation * #1960 enhance_derive_extreme_event: update NEWS * #1960 enhance_derive_extreme_event: fix links * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event: add example * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event:add example and tests for event-specific modes * #1960 enhance_derive_extreme_event: add ignore_event_order argument * #1960 enhance_derive_extreme_event: fix spelling * #1960 enhance_derive_extreme_event: use correct input dataset * #1960 enhance_derive_extreme_event: improve printing of event objects * #1960 enhance_derive_extreme_event: rename keep_vars_source to keep_source_vars * #1960 enhance_derive_extreme_event: add description field * #1960 enhance_derive_extreme_event: address QC comments * #1960 enhance_derive_extreme_event: update man pages * #1960 enhance_derive_extreme_event: remove docs/pkgdown.yml * #1960 enhance_derive_extreme_event: style files * chore: #1960 properly formatted testthat * chore: #1960 fix lint --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2068 Updated `traceability_vars` to `set_values_to` (#2079) * Closes #2068 Updated `traceability_vars` to `set_values_to` * Clarify the explanation for the traceability_vars replacement * Closes #2083 bug adpp and adpc still using admiraltest (#2086) * fix: #2083 using pharmaversesdtm * fix: #2083 using pharmaversesdtm * chore: #2083 renaming datasets * chore: #2083 removing admiral prefix * chore: #2083 removing admiral suffix * chore: #2083 remove admiral suffix * chore: remove admiral prefix * Closes #1859 metadata updated for DAIDs in xlsx file (#2060) * 1859 metadata updated for DAIDs in xlsx file * 1859 metadata for DAIDs finalised * 1859 update data.r for atoxgr_criteria_daids * 1859 update man files * 1859 fix spelling * 1859 updated derive_var_atoxgr to read in DAIDS and create unit tests * 1859 update man pages * 1859 fix STYLER issue * 1859 fix SPELLING * 1859 fix LINTR * 1859 Fix LINTR and add more unit tests * 1859 added Acidosis and Alkalosis and more unit tests * 1859 added more tests and partiallyy update gradin vignette * 1859 all unit tests added * 1859 fix STYLER * 1859 use signif function in metadata * 1859 use signif function in ncictcaev4 and v5 metadata * Update unit test for Cal (Ionized) to test missing ANRHI Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix unit test for Cal (Ionized) Low for missing ANRLO. Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add units to description of Glucose Nonfasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add unit to description of Glucose fasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix typo in description of Triglycerides, Fasting, High for Grade 3 Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * 1859 address last QC comments on unit tests * 1859 update NEWS file * 1859 updated Vignette * 1859 Fix SPELLING * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 address QC comments * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 Fix STYLER issue * 1859 Fix example in function header * 1859 fix LINTR issue --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2050 Remove print fns from pkgdown Reference page (#2087) ref page updates * Closes #1697 add keep_source_vars arg@devel (#2070) * #1697 Added `keep_vars_source` arg in `derive_extreme_records()`, added relevent unit tests and updated NEWS.md. * Updated pkgdown.yml * Undoing renv.lock update * #1697 Updated default from `NULL` to `exprs(everything())` * #1697 Updated wordlist to include 'tidyselect' * #1697 Moved `select()` after `process_set_values_to()` * #1697 Updated `keep_vars_source` to `keep_source_vars` in `derive_extreme_records()` * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_extreme_records.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1697 Reverted changes made to `derive_var_merged_exist_flag()` and updated `derive_extreme_records()` * #1697 Updated 'Details' section to include `keep_source_vars` --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. (#2082) * #1995 Update to add Sophie as Autor and Stefan's R in Pharma presentation. * #1995 Chore: roxygen * #1995 chore:spellcheck and roxygen * #1995 updates to readme with release schedule and 1.0. * grammar fix in readme --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2028 removed erroneous section. updating rules section (#2088) * docs: #2028 removed erroneous section. updating rules section * docs: #2028 news and wordsmithing * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * docs: #2028 lite explanation of h.i. rule --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2091 fixing deprecation messaging in `derive_param_doseint()` (#2092) * feat: #2091 did that work? * chore: #2091 address errors * fixed deprecation warning * deprecation for analysis_var --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> * Fix for Get Started on Webpage (#2093) Update _pkgdown.yml * update readme with admiral release schedule (#2095) Co-authored-by: Zelos Zhu <zdz2101@github.com> --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com> * ignore notes r cmd checks (#2114) * admiral v0.12.1 (#2122) * Closes #2113 fix derive extreme records (#2121) * #2113 fix_derive_extreme_records: update function and tests * #2113 fix_derive_extreme_records: style files * [actions skip] Add/Update README.md for patch * Closes #2109 ADPP template program has x and y variables (#2110) * #2109 ADPP template program has x and y variables: Update to use `derive_vars_merged()` * #2109 Doc: update NEWS for ADPP template change * ignore notes r cmd checks (#2114) --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2112 add `type` to functions downstream of compute_duration() (#2118) * feat: #2112 add type to fxns downstream of compute_duration * feat: #2112 add test type argument for derive_vars_duration * styler and lintr * chore: #2112 adopt feedback * chore: #2112 add upversion on DESCRIPTION * chore: #2112 try inheritParams * chore: #2112 remove mention of default --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Update README.md typo Co-authored-by: Ben Straub <ben.x.straub@gsk.com> --------- Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com>

* Closes #1950 following deprecation process, update Description version and news.md * updating documentation to fix the warnings * added the new tests for minutes and seconds options * Removing references in deprecated functions. * updated comments and applied test_that format * conflicts resolved * Closes #1941 authors contributors@devel (#1967) * Initial edit to `_pkgdown.yml` for #1941 * #1941 re-labelling authors and contributors * #1941 update to enact decision of team regarding who are authors and contributors. * #1941: Chore (spellcheck and man pages and NEWS.md update) * #1941 chore: further updates to spellcheck * #1941: chore: fix space after commas. move some acknowledgees to contributors. link README in authors page. * #1941 chore: roxygenize --------- Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> * Closes #1228 produce bmi records for more visits (#1957) * feat: #1228 Produce BMI records for more visits: Add constant_height parameter * feat: #1228 Produce BMI records for more visits: Update to use constant_by_vars as switch and update examples with more detail. * docs: #1228 Produce BMI records for more visits: Fix typo in NEWS * feat: #1228 Produce BMI records for more visits: Update ADVS template and vignette. * doc: #1228 Produce BMI records for more visits: Add backticks to variable. --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1695 Establish codeowners (#1973) feat: #1695 add gordon and jeff as codeowners Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> * Closes #1974 Swapping out deprecated assertions (#1975) * feat: #1974 try swapping all deprecated assertions * chore: #1974 fix parsing issue that caused vignettes to crash * chore: #1974 simplify by_vars requirement Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> * chore: #264 move assertion to different line --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#1986) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Catch devel up to Admiral v0.11.1 (#1997) (#1999) Admiral v0.11.1 (#1997) * [actions skip] Add/Update README.md for patch * Closes #1962 #1969 admiral 0.11.1 hotfix for get started link, derive_param_tte, derive_vars_joined (#1987) * feat #1962 #1969 param_tte and get started fix * forgot to add updated DESCRIPTION * chore: #1962 thought crossing was dplyr * chore: #1962 account for new assertions * fix: #1962 was missing the reassignment piece? * fix: #1966 crude answer * feat: #1966 potential way of warning users of null new_vars * fix: #1966 add appropriate assertions to get check to go through * fix: #1966 appropriate function fix for order * fix: #1966 vignette named order expression * chore: #1966 try something * chore: #1966 optionality of expressions is tricky * feat: #1966 undo derive_joined stuff * chore: run styler --------- --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Initiate a Stale bot for Issue Triaging (#1992) * Create stale_bot.yml * Update and rename stale_bot.yml to stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Closes #1927 derive param tte@devel (#2000) Removed incorrect reference of start_imputation_flag Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1989 Link Fix in `README.md` (#1994) * Update README.md * Update WORDLIST * Update README.md * Update WORDLIST * chore: #1989 spelling --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1856 Removed the higher order file (#2008) #1856 Removed the higher order file * Update templates.yml (#2026) * Closes #2001 Added processing for missing age_units in `compute_age_years` (#2009) * #2001 added processing for missing age_units in `compute_age_years` * #2001 Chore: styler * #2001 chore: lint * #2001 chore: fix broken links * #2001 - removed for loop, changed unit in `derive_vars_aage`, restored `docs/pkgdown.yml`. * #2001 chore: Fixed docs link * #2001 chore: styler * #2001 implemented prop[er deprecation strategy for `age_unit` in `derive_vars_aage` and added extra test for `age_unit` * #2001 Update NEWS.md as per suggestiom Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update R/compute_age_years.R with correct backquoting Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #2001 version change in deprecation * #2001 insert parenthesis in NEWS.md Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * #2001 chore: roxygen --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1979 Add a flag_all function argument to enhance `derive_var_extreme_flag()` (#2024) * feat: #1979 added the necessary flag_all function argument * feat: #1979 modify check_type to supppress warnings for flag_all = TRUE * chore: #1979 run lintr/styler * chore: #1979 add news blurb * typo * chore: #1979 add additional tests and add roxygen details * chore: #1979 adopt feedback from review * chore: #1979 run styler --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #123 Add Edoardo to status check (#2031) fix: https://github.com/pharmaverse/admiralci/issues/123 add Edoardo to status check * Closes #2014 derive_var_shift change na_val@devel (#2032) * #2014 `na_val` deprecated and `missing_value` inserted into `derive_var_shift`. * #2014 - Update `NEWS.md`. * #2014 - update tests and write deprecation parameter test * #2014 - run required tasks for PR --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2012_derive_vars_dy (#2013) * derive dy_vars by argument .name in across (#2012) use named vector to avoid the variabes end with `_temp` in input dataset * test no error for variable end with `_temp`(#2012) * styled file * add update information for #2012 --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> * Closes #1966 address derive_vars_joined bugs (#2016) * feat: #1966 make our check_type consistent * feat: #1966 hacky solution to null new_vars .join problem * chore: #1966 inserted line in wrong place * feat: #1966 add news blurb for what was done * feat: #1966 add tests * chore: #1966 lintr * chore: #1966 swap appropriate order selection and restore check_type arg * chore: #1966 looks like that fixed it * feat: #1966 issue warning for dataset_add naming conflicts when `new_vars` is NULL * chore: #1966 clean up for readability * chore: #1966 restore original replace_values_by_names * chore: #1966 add additional test to demonstrate how order vars were fixed/selected * feat: #1966 adopt feedback for error messaging of naming conflicts --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2037 deprecate `dataset_expected_obs` for `dataset_ref` in respective functions (#2039) feat: #2037 deprecate `dataset_expected_obs` for `dataset_ref` Co-authored-by: Zelos Zhu <zdz2101@github.com> * Close #1940 Removing unnecessary runtime development-related dependencies (#1978) * feat: #1940 try removing dev deps * chore: #1940 still needs knitr * #1940 diffdf needed for all the testing stuff * chore: #1940 add back rmarkdown Co-authored-by: Adam Foryś <adam.forys@roche.com> --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #1984 Allowing missing trt end date in `derive_var_ontrtfl()` (#2029) * #1984 allowing missing trt end date * Update derive_var_ontrtfl.R * Update derive_var_ontrtfl.R * Increment version number to 0.12.0.9000 * updating version numbers...oops! * Update test-derive_var_ontrtfl.R * Closes #1984 Addressing missing treatment start dates in `derive_var_ontrtfl()` (#2048) addressing missing treatment start dates * Propagate renv.lock from pharmaverse/admiralci (#2046) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * Update .Rbuildignore * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #2033 `derive_var_ontrtfl(span_period)` arg updated to accept T/F (#2044) * span_period arg update * Update derive_var_ontrtfl.R * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * remove space for lintr --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * add admiral src to test codespaces * Revert "add admiral src to test codespaces" This reverts commit 4a60be0d83e5bd9503eb74610160ece31ef86b7e. * Propagate renv.lock from pharmaverse/admiralci (#2058) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #2020 chore: rename wt to weight in compute_egfr (#2045) * code updated * Chore #2020 go through checklist * update .lycheeignore * update .lycheeignore * adjusted templates * chore: removed links from .lycheeignore * chore: #2020 removing file --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2053 Typo in the example `impute_dtc_dt` (#2056) Closes #2053 Typo in the example impute_dtc_dt * update `impute_dtc_dtm` to `impute_dtc_dt` in derive_date_vars.R * update derive_date_vars.Rd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2038 Attach See also to compute functions (#2062) Doc: #2038 Attach See also to compute functions Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> * feat: #2034 show how this can standardize our sub-descriptions * feat: #2034 this does seem to be a better usecase * Closes #2042 fix compute_dtf bug (#2047) * feat: #2042 needs to incorporate date portion and location of the double hyphen to parse out correctly * feat: #2042 add appropriate logic for date-portions * chore: #2042 add news * feat: #2042 address month and day missing * feat: #2042 allow - for "Y" flag --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1968 compute multiple variables in `derive_param_computed()` (#2036) * #1968 compute_multiple_vars: update arguments of derive_param_computed() * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: style files * #1968 compute_multiple_vars: fix R-CMD checks * #1968 compute_multiple_vars: update error message of get_hori_data() * #1968 compute_multiple_vars: improve documentation * #1968 compute_multiple_vars: use deprecation badge * #1968 compute_multiple_vars: use deprecation badge * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1968 compute_multiple_vars: use @keywords internal * #1968 compute_multiple_vars: fix typo in NEWS.md --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * feat: #2034 looks like we can bundle the label into the code chunk too * Closes #1466 Unit test for `print.duplicates()` which closes test coverage gap (#2055) * feat: #2054 remove print.duplciates() * feat: #1466 add appropriate test for print.duplicates * chore: #1466 cleanup duplicate code * feat: #1466 use expect_snapshot() instead --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2040 Update admiral.test to pharmaversesdtm (#2057) * Chore: #2040 Update admiral.test to pharmaversesdtm * Chore: #2040 Update admiraltest to pharmaversesdtm: Update WORDLIST and run styler * #2040 Update admiral.test to pharmaversesdtm: udpate staged_dependencies.yaml * Chore: #2040 Update admiral.test to pharmaversesdtm: rename suppae and admiral_eg. * Chore #2040 Update admiral.test to pharmaversesdtm: Update test-call_derivation.R * Chore: #2040 Update admiral.test to pharmaversesdtm: Update create_query_data.R * Chore: #2040 Update admiral.test to pharmaversesdtm run documentation for create_query_data --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * chore: #2034 show the degree of variation * Propagate renv.lock from pharmaverse/admiralci (#2064) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * #2027 clarify reference_date in derive_vars_dy() (#2063) * change description * updated news.md * closes #2069 bug: EOSSTT derivation fix (#2073) #2069 bug: EOSSTT derivation fix Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2049 Date/Time Imputation Utilities are no Longer listed on pkgdown site (#2076) * utils_impute fns now internal * Update NEWS.md * adding meta.R entry back * Closes #1875 duration and interval time difference types update (#2075) * in progress * updated default to duration instead of interval * style * spelling updates * Update NEWS.md * added pharmaversesdtm Remotes call * Update DESCRIPTION * Update test-compute_duration.R --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * feat: #2034 apply function to all dataset params * chore: #2034 align assertion with description * chore: #2034 fix derive_locf_records * run lintr * chore: #2034 nolint doesn't work in roxygen * Closes #2078 swap out admiral_eg with eg (#2080) feat: #2078 swap out admiral_eg with eg Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1960 enhance derive_extreme_event() (#2015) * #1960 enhance_derive_extreme_event: start a draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: add tests and documentation * #1960 enhance_derive_extreme_event: update NEWS * #1960 enhance_derive_extreme_event: fix links * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event: add example * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event:add example and tests for event-specific modes * #1960 enhance_derive_extreme_event: add ignore_event_order argument * #1960 enhance_derive_extreme_event: fix spelling * #1960 enhance_derive_extreme_event: use correct input dataset * #1960 enhance_derive_extreme_event: improve printing of event objects * #1960 enhance_derive_extreme_event: rename keep_vars_source to keep_source_vars * #1960 enhance_derive_extreme_event: add description field * #1960 enhance_derive_extreme_event: address QC comments * #1960 enhance_derive_extreme_event: update man pages * #1960 enhance_derive_extreme_event: remove docs/pkgdown.yml * #1960 enhance_derive_extreme_event: style files * chore: #1960 properly formatted testthat * chore: #1960 fix lint --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2068 Updated `traceability_vars` to `set_values_to` (#2079) * Closes #2068 Updated `traceability_vars` to `set_values_to` * Clarify the explanation for the traceability_vars replacement * Closes #2083 bug adpp and adpc still using admiraltest (#2086) * fix: #2083 using pharmaversesdtm * fix: #2083 using pharmaversesdtm * chore: #2083 renaming datasets * chore: #2083 removing admiral prefix * chore: #2083 removing admiral suffix * chore: #2083 remove admiral suffix * chore: remove admiral prefix * Closes #1859 metadata updated for DAIDs in xlsx file (#2060) * 1859 metadata updated for DAIDs in xlsx file * 1859 metadata for DAIDs finalised * 1859 update data.r for atoxgr_criteria_daids * 1859 update man files * 1859 fix spelling * 1859 updated derive_var_atoxgr to read in DAIDS and create unit tests * 1859 update man pages * 1859 fix STYLER issue * 1859 fix SPELLING * 1859 fix LINTR * 1859 Fix LINTR and add more unit tests * 1859 added Acidosis and Alkalosis and more unit tests * 1859 added more tests and partiallyy update gradin vignette * 1859 all unit tests added * 1859 fix STYLER * 1859 use signif function in metadata * 1859 use signif function in ncictcaev4 and v5 metadata * Update unit test for Cal (Ionized) to test missing ANRHI Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix unit test for Cal (Ionized) Low for missing ANRLO. Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add units to description of Glucose Nonfasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add unit to description of Glucose fasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix typo in description of Triglycerides, Fasting, High for Grade 3 Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * 1859 address last QC comments on unit tests * 1859 update NEWS file * 1859 updated Vignette * 1859 Fix SPELLING * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 address QC comments * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 Fix STYLER issue * 1859 Fix example in function header * 1859 fix LINTR issue --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2050 Remove print fns from pkgdown Reference page (#2087) ref page updates * Closes #1697 add keep_source_vars arg@devel (#2070) * #1697 Added `keep_vars_source` arg in `derive_extreme_records()`, added relevent unit tests and updated NEWS.md. * Updated pkgdown.yml * Undoing renv.lock update * #1697 Updated default from `NULL` to `exprs(everything())` * #1697 Updated wordlist to include 'tidyselect' * #1697 Moved `select()` after `process_set_values_to()` * #1697 Updated `keep_vars_source` to `keep_source_vars` in `derive_extreme_records()` * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_extreme_records.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1697 Reverted changes made to `derive_var_merged_exist_flag()` and updated `derive_extreme_records()` * #1697 Updated 'Details' section to include `keep_source_vars` --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * missing reroute to get started page * #1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. (#2082) * #1995 Update to add Sophie as Autor and Stefan's R in Pharma presentation. * #1995 Chore: roxygen * #1995 chore:spellcheck and roxygen * #1995 updates to readme with release schedule and 1.0. * grammar fix in readme --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2028 removed erroneous section. updating rules section (#2088) * docs: #2028 removed erroneous section. updating rules section * docs: #2028 news and wordsmithing * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * docs: #2028 lite explanation of h.i. rule --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2091 fixing deprecation messaging in `derive_param_doseint()` (#2092) * feat: #2091 did that work? * chore: #2091 address errors * fixed deprecation warning * deprecation for analysis_var --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> * Fix for Get Started on Webpage (#2093) Update _pkgdown.yml * update readme with admiral release schedule (#2095) Co-authored-by: Zelos Zhu <zdz2101@github.com> * feat: #2034 add testthat file * chore: #2034 styler * Update devel (#2133) * admiral v0.12.0 (#2094) * Closes #1950 following deprecation process, update Description version and news.md * updating documentation to fix the warnings * added the new tests for minutes and seconds options * Removing references in deprecated functions. * updated comments and applied test_that format * conflicts resolved * Closes #1941 authors contributors@devel (#1967) * Initial edit to `_pkgdown.yml` for #1941 * #1941 re-labelling authors and contributors * #1941 update to enact decision of team regarding who are authors and contributors. * #1941: Chore (spellcheck and man pages and NEWS.md update) * #1941 chore: further updates to spellcheck * #1941: chore: fix space after commas. move some acknowledgees to contributors. link README in authors page. * #1941 chore: roxygenize --------- Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> * Closes #1228 produce bmi records for more visits (#1957) * feat: #1228 Produce BMI records for more visits: Add constant_height parameter * feat: #1228 Produce BMI records for more visits: Update to use constant_by_vars as switch and update examples with more detail. * docs: #1228 Produce BMI records for more visits: Fix typo in NEWS * feat: #1228 Produce BMI records for more visits: Update ADVS template and vignette. * doc: #1228 Produce BMI records for more visits: Add backticks to variable. --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1695 Establish codeowners (#1973) feat: #1695 add gordon and jeff as codeowners Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> * Closes #1974 Swapping out deprecated assertions (#1975) * feat: #1974 try swapping all deprecated assertions * chore: #1974 fix parsing issue that caused vignettes to crash * chore: #1974 simplify by_vars requirement Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> * chore: #264 move assertion to different line --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#1986) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Catch devel up to Admiral v0.11.1 (#1997) (#1999) Admiral v0.11.1 (#1997) * [actions skip] Add/Update README.md for patch * Closes #1962 #1969 admiral 0.11.1 hotfix for get started link, derive_param_tte, derive_vars_joined (#1987) * feat #1962 #1969 param_tte and get started fix * forgot to add updated DESCRIPTION * chore: #1962 thought crossing was dplyr * chore: #1962 account for new assertions * fix: #1962 was missing the reassignment piece? * fix: #1966 crude answer * feat: #1966 potential way of warning users of null new_vars * fix: #1966 add appropriate assertions to get check to go through * fix: #1966 appropriate function fix for order * fix: #1966 vignette named order expression * chore: #1966 try something * chore: #1966 optionality of expressions is tricky * feat: #1966 undo derive_joined stuff * chore: run styler --------- --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Initiate a Stale bot for Issue Triaging (#1992) * Create stale_bot.yml * Update and rename stale_bot.yml to stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Update stale-bot.yml * Closes #1927 derive param tte@devel (#2000) Removed incorrect reference of start_imputation_flag Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1989 Link Fix in `README.md` (#1994) * Update README.md * Update WORDLIST * Update README.md * Update WORDLIST * chore: #1989 spelling --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #1856 Removed the higher order file (#2008) #1856 Removed the higher order file * Update templates.yml (#2026) * Closes #2001 Added processing for missing age_units in `compute_age_years` (#2009) * #2001 added processing for missing age_units in `compute_age_years` * #2001 Chore: styler * #2001 chore: lint * #2001 chore: fix broken links * #2001 - removed for loop, changed unit in `derive_vars_aage`, restored `docs/pkgdown.yml`. * #2001 chore: Fixed docs link * #2001 chore: styler * #2001 implemented prop[er deprecation strategy for `age_unit` in `derive_vars_aage` and added extra test for `age_unit` * #2001 Update NEWS.md as per suggestiom Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update R/compute_age_years.R with correct backquoting Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #2001 version change in deprecation * #2001 insert parenthesis in NEWS.md Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * #2001 chore: roxygen --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1979 Add a flag_all function argument to enhance `derive_var_extreme_flag()` (#2024) * feat: #1979 added the necessary flag_all function argument * feat: #1979 modify check_type to supppress warnings for flag_all = TRUE * chore: #1979 run lintr/styler * chore: #1979 add news blurb * typo * chore: #1979 add additional tests and add roxygen details * chore: #1979 adopt feedback from review * chore: #1979 run styler --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #123 Add Edoardo to status check (#2031) fix: https://github.com/pharmaverse/admiralci/issues/123 add Edoardo to status check * Closes #2014 derive_var_shift change na_val@devel (#2032) * #2014 `na_val` deprecated and `missing_value` inserted into `derive_var_shift`. * #2014 - Update `NEWS.md`. * #2014 - update tests and write deprecation parameter test * #2014 - run required tasks for PR --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2012_derive_vars_dy (#2013) * derive dy_vars by argument .name in across (#2012) use named vector to avoid the variabes end with `_temp` in input dataset * test no error for variable end with `_temp`(#2012) * styled file * add update information for #2012 --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> * Closes #1966 address derive_vars_joined bugs (#2016) * feat: #1966 make our check_type consistent * feat: #1966 hacky solution to null new_vars .join problem * chore: #1966 inserted line in wrong place * feat: #1966 add news blurb for what was done * feat: #1966 add tests * chore: #1966 lintr * chore: #1966 swap appropriate order selection and restore check_type arg * chore: #1966 looks like that fixed it * feat: #1966 issue warning for dataset_add naming conflicts when `new_vars` is NULL * chore: #1966 clean up for readability * chore: #1966 restore original replace_values_by_names * chore: #1966 add additional test to demonstrate how order vars were fixed/selected * feat: #1966 adopt feedback for error messaging of naming conflicts --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2037 deprecate `dataset_expected_obs` for `dataset_ref` in respective functions (#2039) feat: #2037 deprecate `dataset_expected_obs` for `dataset_ref` Co-authored-by: Zelos Zhu <zdz2101@github.com> * Close #1940 Removing unnecessary runtime development-related dependencies (#1978) * feat: #1940 try removing dev deps * chore: #1940 still needs knitr * #1940 diffdf needed for all the testing stuff * chore: #1940 add back rmarkdown Co-authored-by: Adam Foryś <adam.forys@roche.com> --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #1984 Allowing missing trt end date in `derive_var_ontrtfl()` (#2029) * #1984 allowing missing trt end date * Update derive_var_ontrtfl.R * Update derive_var_ontrtfl.R * Increment version number to 0.12.0.9000 * updating version numbers...oops! * Update test-derive_var_ontrtfl.R * Closes #1984 Addressing missing treatment start dates in `derive_var_ontrtfl()` (#2048) addressing missing treatment start dates * Propagate renv.lock from pharmaverse/admiralci (#2046) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci * Update .Rbuildignore * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> * Closes #2033 `derive_var_ontrtfl(span_period)` arg updated to accept T/F (#2044) * span_period arg update * Update derive_var_ontrtfl.R * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_var_ontrtfl.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * remove space for lintr --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * add admiral src to test codespaces * Revert "add admiral src to test codespaces" This reverts commit 4a60be0d83e5bd9503eb74610160ece31ef86b7e. * Propagate renv.lock from pharmaverse/admiralci (#2058) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #2020 chore: rename wt to weight in compute_egfr (#2045) * code updated * Chore #2020 go through checklist * update .lycheeignore * update .lycheeignore * adjusted templates * chore: removed links from .lycheeignore * chore: #2020 removing file --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2053 Typo in the example `impute_dtc_dt` (#2056) Closes #2053 Typo in the example impute_dtc_dt * update `impute_dtc_dtm` to `impute_dtc_dt` in derive_date_vars.R * update derive_date_vars.Rd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2038 Attach See also to compute functions (#2062) Doc: #2038 Attach See also to compute functions Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> * Closes #2042 fix compute_dtf bug (#2047) * feat: #2042 needs to incorporate date portion and location of the double hyphen to parse out correctly * feat: #2042 add appropriate logic for date-portions * chore: #2042 add news * feat: #2042 address month and day missing * feat: #2042 allow - for "Y" flag --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1968 compute multiple variables in `derive_param_computed()` (#2036) * #1968 compute_multiple_vars: update arguments of derive_param_computed() * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: update documentation * #1968 compute_multiple_vars: style files * #1968 compute_multiple_vars: fix R-CMD checks * #1968 compute_multiple_vars: update error message of get_hori_data() * #1968 compute_multiple_vars: improve documentation * #1968 compute_multiple_vars: use deprecation badge * #1968 compute_multiple_vars: use deprecation badge * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1968 compute_multiple_vars: use @keywords internal * #1968 compute_multiple_vars: fix typo in NEWS.md --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #1466 Unit test for `print.duplicates()` which closes test coverage gap (#2055) * feat: #2054 remove print.duplciates() * feat: #1466 add appropriate test for print.duplicates * chore: #1466 cleanup duplicate code * feat: #1466 use expect_snapshot() instead --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2040 Update admiral.test to pharmaversesdtm (#2057) * Chore: #2040 Update admiral.test to pharmaversesdtm * Chore: #2040 Update admiraltest to pharmaversesdtm: Update WORDLIST and run styler * #2040 Update admiral.test to pharmaversesdtm: udpate staged_dependencies.yaml * Chore: #2040 Update admiral.test to pharmaversesdtm: rename suppae and admiral_eg. * Chore #2040 Update admiral.test to pharmaversesdtm: Update test-call_derivation.R * Chore: #2040 Update admiral.test to pharmaversesdtm: Update create_query_data.R * Chore: #2040 Update admiral.test to pharmaversesdtm run documentation for create_query_data --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Propagate renv.lock from pharmaverse/admiralci (#2064) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * #2027 clarify reference_date in derive_vars_dy() (#2063) * change description * updated news.md * closes #2069 bug: EOSSTT derivation fix (#2073) #2069 bug: EOSSTT derivation fix Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2049 Date/Time Imputation Utilities are no Longer listed on pkgdown site (#2076) * utils_impute fns now internal * Update NEWS.md * adding meta.R entry back * Closes #1875 duration and interval time difference types update (#2075) * in progress * updated default to duration instead of interval * style * spelling updates * Update NEWS.md * added pharmaversesdtm Remotes call * Update DESCRIPTION * Update test-compute_duration.R --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2078 swap out admiral_eg with eg (#2080) feat: #2078 swap out admiral_eg with eg Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #1960 enhance derive_extreme_event() (#2015) * #1960 enhance_derive_extreme_event: start a draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: continue draft * #1960 enhance_derive_extreme_event: add tests and documentation * #1960 enhance_derive_extreme_event: update NEWS * #1960 enhance_derive_extreme_event: fix links * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event: add example * #1960 enhance_derive_extreme_event: style files * #1960 enhance_derive_extreme_event:add example and tests for event-specific modes * #1960 enhance_derive_extreme_event: add ignore_event_order argument * #1960 enhance_derive_extreme_event: fix spelling * #1960 enhance_derive_extreme_event: use correct input dataset * #1960 enhance_derive_extreme_event: improve printing of event objects * #1960 enhance_derive_extreme_event: rename keep_vars_source to keep_source_vars * #1960 enhance_derive_extreme_event: add description field * #1960 enhance_derive_extreme_event: address QC comments * #1960 enhance_derive_extreme_event: update man pages * #1960 enhance_derive_extreme_event: remove docs/pkgdown.yml * #1960 enhance_derive_extreme_event: style files * chore: #1960 properly formatted testthat * chore: #1960 fix lint --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #2068 Updated `traceability_vars` to `set_values_to` (#2079) * Closes #2068 Updated `traceability_vars` to `set_values_to` * Clarify the explanation for the traceability_vars replacement * Closes #2083 bug adpp and adpc still using admiraltest (#2086) * fix: #2083 using pharmaversesdtm * fix: #2083 using pharmaversesdtm * chore: #2083 renaming datasets * chore: #2083 removing admiral prefix * chore: #2083 removing admiral suffix * chore: #2083 remove admiral suffix * chore: remove admiral prefix * Closes #1859 metadata updated for DAIDs in xlsx file (#2060) * 1859 metadata updated for DAIDs in xlsx file * 1859 metadata for DAIDs finalised * 1859 update data.r for atoxgr_criteria_daids * 1859 update man files * 1859 fix spelling * 1859 updated derive_var_atoxgr to read in DAIDS and create unit tests * 1859 update man pages * 1859 fix STYLER issue * 1859 fix SPELLING * 1859 fix LINTR * 1859 Fix LINTR and add more unit tests * 1859 added Acidosis and Alkalosis and more unit tests * 1859 added more tests and partiallyy update gradin vignette * 1859 all unit tests added * 1859 fix STYLER * 1859 use signif function in metadata * 1859 use signif function in ncictcaev4 and v5 metadata * Update unit test for Cal (Ionized) to test missing ANRHI Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix unit test for Cal (Ionized) Low for missing ANRLO. Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add units to description of Glucose Nonfasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Add unit to description of Glucose fasting, High Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Fix typo in description of Triglycerides, Fasting, High for Grade 3 Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * 1859 address last QC comments on unit tests * 1859 update NEWS file * 1859 updated Vignette * 1859 Fix SPELLING * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update NEWS.md following QC comment Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 address QC comments * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Update vignettes/lab_grading.Rmd Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * 1859 Fix STYLER issue * 1859 Fix example in function header * 1859 fix LINTR issue --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2050 Remove print fns from pkgdown Reference page (#2087) ref page updates * Closes #1697 add keep_source_vars arg@devel (#2070) * #1697 Added `keep_vars_source` arg in `derive_extreme_records()`, added relevent unit tests and updated NEWS.md. * Updated pkgdown.yml * Undoing renv.lock update * #1697 Updated default from `NULL` to `exprs(everything())` * #1697 Updated wordlist to include 'tidyselect' * #1697 Moved `select()` after `process_set_values_to()` * #1697 Updated `keep_vars_source` to `keep_source_vars` in `derive_extreme_records()` * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update NEWS.md Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update R/derive_extreme_records.R Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1697 Reverted changes made to `derive_var_merged_exist_flag()` and updated `derive_extreme_records()` * #1697 Updated 'Details' section to include `keep_source_vars` --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * #1995 Update to add Sophie as Author and Stefan's R in Pharma presentation. (#2082) * #1995 Update to add Sophie as Autor and Stefan's R in Pharma presentation. * #1995 Chore: roxygen * #1995 chore:spellcheck and roxygen * #1995 updates to readme with release schedule and 1.0. * grammar fix in readme --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2028 removed erroneous section. updating rules section (#2088) * docs: #2028 removed erroneous section. updating rules section * docs: #2028 news and wordsmithing * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Update vignettes/imputation.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * docs: #2028 lite explanation of h.i. rule --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #2091 fixing deprecation messaging in `derive_param_doseint()` (#2092) * feat: #2091 did that work? * chore: #2091 address errors * fixed deprecation warning * deprecation for analysis_var --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> * Fix for Get Started on Webpage (#2093) Update _pkgdown.yml * update readme with admiral release schedule (#2095) Co-authored-by: Zelos Zhu <zdz2101@github.com> --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com> * ignore notes r cmd checks (#2114) * admiral v0.12.1 (#2122) * Closes #2113 fix derive extreme records (#2121) * #2113 fix_derive_extreme_records: update function and tests * #2113 fix_derive_extreme_records: style files * [actions skip] Add/Update README.md for patch * Closes #2109 ADPP template program has x and y variables (#2110) * #2109 ADPP template program has x and y variables: Update to use `derive_vars_merged()` * #2109 Doc: update NEWS for ADPP template change * ignore notes r cmd checks (#2114) --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #2112 add `type` to functions downstream of compute_duration() (#2118) * feat: #2112 add type to fxns downstream of compute_duration * feat: #2112 add test type argument for derive_vars_duration * styler and lintr * chore: #2112 adopt feedback * chore: #2112 add upversion on DESCRIPTION * chore: #2112 try inheritParams * chore: #2112 remove mention of default --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Update README.md typo Co-authored-by: Ben Straub <ben.x.straub@gsk.com> --------- Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> --------- Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com> * remove merge conflict nonsense * forgot test suite * bad styling job from copy/paste * feat: #2034 add back new blurb for what occured --------- Co-authored-by: sadchla-codes <sadchla.mathieu@gmail.com> Co-authored-by: Sadchla Mascary <112789549+sadchla-codes@users.noreply.github.com> Co-authored-by: lomaxj1 <jennifer.lomax@roche.com> Co-authored-by: Jennifer Lomax <125990075+J-Lox@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: Mancini, Edoardo {MDBB~Welwyn} <edoardo.mancini@roche.com> Co-authored-by: Jeff Dickinson <jeffreyd@gene.com> Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: GitHub Actions <action@github.com> Co-authored-by: SyedMubasheer <106958950+SyedMubasheer@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: asha-gsk <134052893+ashachakma@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: ynsec37 <98389771+ynsec37@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@roche.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Daphne Grasselly <daphne.grasselly@roche.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Gordon Miller <80953007+millerg23@users.noreply.github.com> Co-authored-by: G Gayatri <103511237+gg106046@users.noreply.github.com> Co-authored-by: Daphné Grasselly <56442075+dgrassellyb@users.noreply.github.com>

* docs: #283 update description and news * closes #286 commit messaging, new r-cmd vignette (#291) * docs: #286 commit messaging, new r-cmd vignette * chore: #286 spelling * docs: #286 squash and merge blurb * Update vignettes/git_usage.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * chore: #286 news update --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #271, #213, #260, #240 Documentation Update of get_datasets(); keep_source_vars argument; @family tag; compute_ functions (#287) * docs: #271 #213 clarify get_datasets and add keep_source_vars to prog strat * docs: #260 cleanup @family mentions * docs: #240 add blurb about compute functions * docs: #271 #213 #240 #260 add news blurb * adopt suggestion for family/keywords Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * docs #271 adopt get_dataset feedback * docs: #213 #240 adopt recommendations from PR * chore: #240 add BMI to WORDLIST for spellcheck * chore: #271 #213 #260 adopt feedback --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #264, #288 cleanup assertions and continue deprecation process (#289) * feat: #288 cleanup deprecation process * feat: #264 deprecate assert_function * test: #264 cleanup some tests in assert_function, confused how others would go * test: #264 rewrite tests in a more logical way * chore: #264 run styler/lintr * chore: #288 revert back to devel test file * chore: #288 properly fix assert_order_vars again * feat: #264 begin deprecation of redundant assertions * feat: #288 deprecate assert_named_exprs * deprecate assert_has_variables properly #264 * chore: #264 run styler * docs: #264 add blurb in news for the deprecated assertions * chore: #264 fix description version and remove deprecated examples --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Propagate renv.lock from pharmaverse/admiralci (#294) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Closes #22 #181 #201 #292 #298 Variety of small-scale general documentation updates (#303) * feat: #22 add documentation to friendly_type_of * feat: #181 add the appropriate URL * feat: #201 #292 add documentation about PR guidance and codeowners * chore: update wordlist for codeowners * chore: add NEWS --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #302 Adding Snapshot testing guidance to unit testing vignette (#308) * Update unit_test_guidance.Rmd * Update NEWS.md * Update NEWS.md * Closes #301: (#307) * #301: edoardo added as author, and author/contributor distinction implemented as in core admiral package * #301 chore: document * Propagate renv.lock from pharmaverse/admiralci (#310) * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> * Closes #295 template documentation@devel (#300) * #295 set up package extension guidance page * #295 fix vignetteindexentry * #295 chore: spellcheck * #295 chore: fix encoding issues in vignettes that prevented package from being built * #295: updates following review * #295 Chore: spellcheck * Update vignettes/package_extensions.Rmd Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * #295 update to refer to admiraldev devel site * #295 Chore: spellcheck --------- Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * Closes #296 document_missing_value_s@devel (#311) * #296 - `missing_value` and `missing_values` added to the table of common arguments. * #296 - add in discussion of when to use singular vs plural arguments to programming strategy. * #296 - run checks required for PR and update NEWS.md. * #296 - Update according to requested changes. * #296 - revert the 'wrapped' changes in the programming strategy vignette * #296 - re-insert the new text into the programming strategy vignette, altered according to changes requested. * #296 - update NEWS.md with changes requested and run the required checks for PR. * Closes #282: Test Data Guidance vignette (#293) * #282: add test_data_guidance.Rmd, copy from admiraldata README devel * #282: update .yml * #282: add link for packages, remove SDTM, add naming conventions for program name * #282 spelling * #282: link to two data packages * #282: updated wordlist * #282: update pharmaverseadam description --------- Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#314) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#315) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #306 argument descriptions added to table (#320) argument descriptions added to table Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #316 remove messaging that includes "-" as year not handled (#317) * feat: #316 remove messaging that includes "-" as year not handled * feat: #316 replace warning message * chore: #316 fix warning message and typos * chore: #316 add news blurb --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #318 #321 Documentation updates around admiral.test, staged dependencies, and function arguments (#323) * Fix hardcoded URL (#326) Resolves pharmaverse/admiraldev#325 * Closes #312 breakup wall of text (#319) * brick in the wall * remove special characters from image name * remove special characters from image name * replaced iframe with png * fixed image reference --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #328 add missing news entries (#329) * feat: #295 add missing news entries * feat: #295 add missing news entries * fixed it * feat: add news entry for #306 * chore: #312 missing reference * chore: fix link that pointed to merged branch and use devel * Update NEWS.md --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com>

…333) * docs: #283 update description and news * closes #286 commit messaging, new r-cmd vignette (#291) * docs: #286 commit messaging, new r-cmd vignette * chore: #286 spelling * docs: #286 squash and merge blurb * Update vignettes/git_usage.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * chore: #286 news update --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #271, #213, #260, #240 Documentation Update of get_datasets(); keep_source_vars argument; @family tag; compute_ functions (#287) * docs: #271 #213 clarify get_datasets and add keep_source_vars to prog strat * docs: #260 cleanup @family mentions * docs: #240 add blurb about compute functions * docs: #271 #213 #240 #260 add news blurb * adopt suggestion for family/keywords Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * docs #271 adopt get_dataset feedback * docs: #213 #240 adopt recommendations from PR * chore: #240 add BMI to WORDLIST for spellcheck * chore: #271 #213 #260 adopt feedback --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #264, #288 cleanup assertions and continue deprecation process (#289) * feat: #288 cleanup deprecation process * feat: #264 deprecate assert_function * test: #264 cleanup some tests in assert_function, confused how others would go * test: #264 rewrite tests in a more logical way * chore: #264 run styler/lintr * chore: #288 revert back to devel test file * chore: #288 properly fix assert_order_vars again * feat: #264 begin deprecation of redundant assertions * feat: #288 deprecate assert_named_exprs * deprecate assert_has_variables properly #264 * chore: #264 run styler * docs: #264 add blurb in news for the deprecated assertions * chore: #264 fix description version and remove deprecated examples --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Propagate renv.lock from pharmaverse/admiralci (#294) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Closes #22 #181 #201 #292 #298 Variety of small-scale general documentation updates (#303) * feat: #22 add documentation to friendly_type_of * feat: #181 add the appropriate URL * feat: #201 #292 add documentation about PR guidance and codeowners * chore: update wordlist for codeowners * chore: add NEWS --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #302 Adding Snapshot testing guidance to unit testing vignette (#308) * Update unit_test_guidance.Rmd * Update NEWS.md * Update NEWS.md * Closes #301: (#307) * #301: edoardo added as author, and author/contributor distinction implemented as in core admiral package * #301 chore: document * Propagate renv.lock from pharmaverse/admiralci (#310) * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> * Closes #295 template documentation@devel (#300) * #295 set up package extension guidance page * #295 fix vignetteindexentry * #295 chore: spellcheck * #295 chore: fix encoding issues in vignettes that prevented package from being built * #295: updates following review * #295 Chore: spellcheck * Update vignettes/package_extensions.Rmd Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * #295 update to refer to admiraldev devel site * #295 Chore: spellcheck --------- Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * Closes #296 document_missing_value_s@devel (#311) * #296 - `missing_value` and `missing_values` added to the table of common arguments. * #296 - add in discussion of when to use singular vs plural arguments to programming strategy. * #296 - run checks required for PR and update NEWS.md. * #296 - Update according to requested changes. * #296 - revert the 'wrapped' changes in the programming strategy vignette * #296 - re-insert the new text into the programming strategy vignette, altered according to changes requested. * #296 - update NEWS.md with changes requested and run the required checks for PR. * Closes #282: Test Data Guidance vignette (#293) * #282: add test_data_guidance.Rmd, copy from admiraldata README devel * #282: update .yml * #282: add link for packages, remove SDTM, add naming conventions for program name * #282 spelling * #282: link to two data packages * #282: updated wordlist * #282: update pharmaverseadam description --------- Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#314) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#315) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #306 argument descriptions added to table (#320) argument descriptions added to table Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #316 remove messaging that includes "-" as year not handled (#317) * feat: #316 remove messaging that includes "-" as year not handled * feat: #316 replace warning message * chore: #316 fix warning message and typos * chore: #316 add news blurb --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #318 #321 Documentation updates around admiral.test, staged dependencies, and function arguments (#323) * Fix hardcoded URL (#326) Resolves pharmaverse/admiraldev#325 * Closes #312 breakup wall of text (#319) * brick in the wall * remove special characters from image name * remove special characters from image name * replaced iframe with png * fixed image reference --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #328 add missing news entries (#329) * feat: #295 add missing news entries * feat: #295 add missing news entries * fixed it * feat: add news entry for #306 * chore: #312 missing reference * chore: fix link that pointed to merged branch and use devel * Update NEWS.md --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * feat: #233 documentation for quoting * feat: #324 add footnotes blurb * feat: #332 add blurb for roxygen standardization * feat: #233 #324 #332 adopt feedback * italicize phrase * skip line to make markdown look correct * chore: run use_verion("dev") * feat: adding post-release cleanup stuff too * forgot line * accidental push * chore: fix tests * always is only a `deprecate_warn()` argument * .github folder updates * yaml syntax * fix link --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com>

* docs: #283 update description and news * closes #286 commit messaging, new r-cmd vignette (#291) * docs: #286 commit messaging, new r-cmd vignette * chore: #286 spelling * docs: #286 squash and merge blurb * Update vignettes/git_usage.Rmd Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * chore: #286 news update --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #271, #213, #260, #240 Documentation Update of get_datasets(); keep_source_vars argument; @family tag; compute_ functions (#287) * docs: #271 #213 clarify get_datasets and add keep_source_vars to prog strat * docs: #260 cleanup @family mentions * docs: #240 add blurb about compute functions * docs: #271 #213 #240 #260 add news blurb * adopt suggestion for family/keywords Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * docs #271 adopt get_dataset feedback * docs: #213 #240 adopt recommendations from PR * chore: #240 add BMI to WORDLIST for spellcheck * chore: #271 #213 #260 adopt feedback --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * Closes #264, #288 cleanup assertions and continue deprecation process (#289) * feat: #288 cleanup deprecation process * feat: #264 deprecate assert_function * test: #264 cleanup some tests in assert_function, confused how others would go * test: #264 rewrite tests in a more logical way * chore: #264 run styler/lintr * chore: #288 revert back to devel test file * chore: #288 properly fix assert_order_vars again * feat: #264 begin deprecation of redundant assertions * feat: #288 deprecate assert_named_exprs * deprecate assert_has_variables properly #264 * chore: #264 run styler * docs: #264 add blurb in news for the deprecated assertions * chore: #264 fix description version and remove deprecated examples --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Propagate renv.lock from pharmaverse/admiralci (#294) renv update from pharmaverse/admiralci Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> * Closes #22 #181 #201 #292 #298 Variety of small-scale general documentation updates (#303) * feat: #22 add documentation to friendly_type_of * feat: #181 add the appropriate URL * feat: #201 #292 add documentation about PR guidance and codeowners * chore: update wordlist for codeowners * chore: add NEWS --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #302 Adding Snapshot testing guidance to unit testing vignette (#308) * Update unit_test_guidance.Rmd * Update NEWS.md * Update NEWS.md * Closes #301: (#307) * #301: edoardo added as author, and author/contributor distinction implemented as in core admiral package * #301 chore: document * Propagate renv.lock from pharmaverse/admiralci (#310) * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> * Closes #295 template documentation@devel (#300) * #295 set up package extension guidance page * #295 fix vignetteindexentry * #295 chore: spellcheck * #295 chore: fix encoding issues in vignettes that prevented package from being built * #295: updates following review * #295 Chore: spellcheck * Update vignettes/package_extensions.Rmd Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * #295 update to refer to admiraldev devel site * #295 Chore: spellcheck --------- Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> * Closes #296 document_missing_value_s@devel (#311) * #296 - `missing_value` and `missing_values` added to the table of common arguments. * #296 - add in discussion of when to use singular vs plural arguments to programming strategy. * #296 - run checks required for PR and update NEWS.md. * #296 - Update according to requested changes. * #296 - revert the 'wrapped' changes in the programming strategy vignette * #296 - re-insert the new text into the programming strategy vignette, altered according to changes requested. * #296 - update NEWS.md with changes requested and run the required checks for PR. * Closes #282: Test Data Guidance vignette (#293) * #282: add test_data_guidance.Rmd, copy from admiraldata README devel * #282: update .yml * #282: add link for packages, remove SDTM, add naming conventions for program name * #282 spelling * #282: link to two data packages * #282: updated wordlist * #282: update pharmaverseadam description --------- Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#314) renv / codespaces update from pharmaverse/admiralci Co-authored-by: galachad <galachad@users.noreply.github.com> * Propagate renv.lock from pharmaverse/admiralci (#315) * renv / codespaces update from pharmaverse/admiralci * renv / codespaces update from pharmaverse/admiralci --------- Co-authored-by: galachad <galachad@users.noreply.github.com> * Closes #306 argument descriptions added to table (#320) argument descriptions added to table Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #316 remove messaging that includes "-" as year not handled (#317) * feat: #316 remove messaging that includes "-" as year not handled * feat: #316 replace warning message * chore: #316 fix warning message and typos * chore: #316 add news blurb --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> * Closes #318 #321 Documentation updates around admiral.test, staged dependencies, and function arguments (#323) * Fix hardcoded URL (#326) Resolves pharmaverse/admiraldev#325 * Closes #312 breakup wall of text (#319) * brick in the wall * remove special characters from image name * remove special characters from image name * replaced iframe with png * fixed image reference --------- Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> * Closes #328 add missing news entries (#329) * feat: #295 add missing news entries * feat: #295 add missing news entries * fixed it * feat: add news entry for #306 * chore: #312 missing reference * chore: fix link that pointed to merged branch and use devel * Update NEWS.md --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> * GitFlow Migration * rename to match repo/pkg name * Update release_strategy.Rmd * progress * chore: branch image and main * chore: images updated to our modern times * docs: new images, removed most of the action sections * chore: delete dev process * chore: new blurb for the people --------- Co-authored-by: Zelos Zhu <zdz2101@github.com> Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: pharmaverse-bot <113703390+pharmaverse-bot@users.noreply.github.com> Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> Co-authored-by: galachad <galachad@users.noreply.github.com> Co-authored-by: Adam Foryś <adam.forys@gmail.com> Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com> Co-authored-by: Sophie Shapcott <90790226+sophie-gem@users.noreply.github.com> Co-authored-by: Kangjie Zhang <47867131+kaz462@users.noreply.github.com> Co-authored-by: StefanThoma <40463122+StefanThoma@users.noreply.github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com>

koegerr added the ADEG label Jun 22, 2021

duniek changed the title ~~create a functional workflow for ADEG and assess needed functionality (2h)~~ create a functional workflow for ADEG and assess needed functionality (8h) Jun 23, 2021

duniek assigned millerg23 and kabis-ops Jun 23, 2021

duniek closed this as completed Jul 6, 2021

zdz2101 pushed a commit that referenced this issue Jun 29, 2023

chore: #264 move assertion to different line

69d1385

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create a functional workflow for ADEG and assess needed functionality (8h) #264

create a functional workflow for ADEG and assess needed functionality (8h) #264

koegerr commented Jun 22, 2021 •

edited by duniek

Loading

kabis-ops commented Jun 29, 2021

create a functional workflow for ADEG and assess needed functionality (8h) #264

create a functional workflow for ADEG and assess needed functionality (8h) #264

Comments

koegerr commented Jun 22, 2021 • edited by duniek Loading

kabis-ops commented Jun 29, 2021

koegerr commented Jun 22, 2021 •

edited by duniek

Loading