closes #20 pull request template #128
Conversation
|
@bms63 @StefanThoma any idea how I can address this, it feel like I'm missing something. when I click on the links it does take me to the website, so I'm not sure why it can't be access/check with linkChecker. |
.github/pull_request_template.md
Outdated
|
|
||
| - [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side | ||
| - [ ] Run the script from `CICD.R` line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file! | ||
| - [ ] Choose (possibly several) `tag(s)` or categories from the current list: `c("metadata", "submission", "qc", "ADaMs", "SDTMs", "community", "conferences", "admiral", "roak", "xportr", "metatools", "metacore")` for your blog post. If you cannot find anything that fits your blog post, add your own tag! |
There was a problem hiding this comment.
| - [ ] Choose (possibly several) `tag(s)` or categories from the current list: `c("metadata", "submission", "qc", "ADaMs", "SDTMs", "community", "conferences", "admiral", "roak", "xportr", "metatools", "metacore")` for your blog post. If you cannot find anything that fits your blog post, add your own tag! | |
| - [ ] Choose (possibly several) `tag(s)` or categories from the current list: `c("metadata", "submission", "qc", "ADaMs", "SDTMs", "community", "conferences", "admiral", "roak", "xportr", "metatools", "metacore")` for your blog post. If you cannot find anything that fits your blog post, add your own tag! | |
| We occasionally tidy up all `tags` for consistency. |
There was a problem hiding this comment.
@StefanThoma Not sure I understand, are you suggesting adding We occasionally tidy up all tags for consistency. to check 7 ?
.github/pull_request_template.md
Outdated
| - [ ] Blog post is under a 10 minute read | ||
| - [ ] Blog post is *short*, *personalized*, *reproducible* and *readable* | ||
| - [ ] Address all merge conflicts and resolve appropriately | ||
| - [ ] Poke two or three of us to do a review! |
There was a problem hiding this comment.
More specific is better:
| - [ ] Poke two or three of us to do a review! | |
| - [ ] Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR. |
|
Also:
|
|
thanks @StefanThoma |
Sorry, not sure what you are refering to. |
|
|
We can just add it to |
Okay, I will do that in this PR and also link it to that issue #127 |
|
@StefanThoma @bms63 @manciniedoardo Please let me know if there is anything I should update in this PR |
|
|
||
| - [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side | ||
| - [ ] Run the script from `CICD.R` line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file! | ||
| - [ ] Choose (possibly several) `tag(s)` or categories from the current list: `c("metadata", "submission", "qc", "ADaMs", "SDTMs", "community", "conferences", "admiral", "roak", "xportr", "metatools", "metacore")` for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up all `tags` for consistency. |
There was a problem hiding this comment.
Can you make a issue as we need to revisit the tags and clean them up. probably less package specific and more general themes?
No description provided.