Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up files, typos, source code linked #56

Merged
merged 5 commits into from
Jun 27, 2023
Merged

chore: clean up files, typos, source code linked #56

merged 5 commits into from
Jun 27, 2023

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Jun 27, 2023

Hey all

Little clean up before we go live!!

@bms63 bms63 requested review from StefanThoma and kaz462 June 27, 2023 14:13
Copy link
Collaborator

@kaz462 kaz462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up, looks great! @bms63

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, still a couple of things to fix.
Added date on folder name is more of a nice consistency across the blog, but happy to discuss.
Also has impact on the URL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the date of the folder so it matches the number in the quarto document

posts/2023-01-09_welcome/index.qmd Outdated Show resolved Hide resolved
R/appendix.R Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this appendix work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it create a link to the source code for the file above the citation.

image

When we get a little more stable - we should start setting up the renv.lock as this will link to R environment.

posts/2023-06-19_hackathon_app/index.qmd Show resolved Hide resolved
posts/2023-06-19_hackathon_writeup/index.qmd Show resolved Hide resolved
posts/admiral/valuelevel/derive_param_computed.qmd Outdated Show resolved Hide resolved
@bms63 bms63 merged commit 0fb5c11 into main Jun 27, 2023
4 checks passed
@bms63 bms63 deleted the typos_etc branch June 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants