Skip to content

Commit

Permalink
Avoid partial argument match of 'label' to 'labels' in ggplot2::scale…
Browse files Browse the repository at this point in the history
…_y_continuous (#211)

* Avoid partial argument match of 'label' to 'labels' in ggplot2::scale_y_continuous

* small doc updates

* bump version number

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
  • Loading branch information
DanChaltiel and ddsjoberg committed May 17, 2024
1 parent 51910af commit 055b7a7
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 10 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ggsurvfit
Title: Flexible Time-to-Event Figures
Version: 1.1.0.9000
Version: 1.1.0.9001
Authors@R: c(
person("Daniel D.", "Sjoberg", , "danield.sjoberg@gmail.com", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0003-0862-2018")),
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ggsurvfit (development version)

* Correcting an argument name partial match in `ggplot2::scale_*(labels)`. (#211, @DanChaltiel)

# ggsurvfit 1.1.0

* We now allow for negative follow-up times in `tidy_survfit()` (and subsequently `ggsurvfit()`). When negative follow-up times are present users should specify `survfit(start.time)` and we print a note to this effect when not set. (#192)
Expand Down
2 changes: 1 addition & 1 deletion R/scale_ggsurvfit.R
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ update_scale_ggsurvfit <- function(p, scale_ggsurvfit_empty_list) {
y_scale_defaults <-
list(
expand = c(0.025, 0),
label =
labels =
switch(rlang::is_installed("scales", version = "1.1.0"), scales::label_percent()) %||%
label_percent_imposter
)
Expand Down
1 change: 1 addition & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ggeasy
gghighlight
ggplot
ggplots
glyphs
grey
gtable
linetype
Expand Down
47 changes: 39 additions & 8 deletions man/stepribbon.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 055b7a7

Please sign in to comment.