New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proportional layout and tests #261
Conversation
Unrelated test failures. |
Given:
that element can have as children elements like this:
The The child's constraints can look like this, too:
Both |
super thanks |
Thanks @tinchodias ! |
Request from Stef after the experience with Morphic's layout.
I removed I have another discussion: |
Thanks Martín,
Why do not use simply left: right: etc. ?
like [:c | c proportional horizontal left: 0.5 ]
Pierre
De : Martín Dias ***@***.***>
Envoyé : vendredi 26 mai 2023 16:34
À : pharo-graphics/Bloc ***@***.***>
Cc : Pierre Laborde ***@***.***>; Comment ***@***.***>
Objet : Re: [pharo-graphics/Bloc] Add proportional layout and tests (PR #261)
I removed [:c | c proportional fractions: Rectangle ... ] API after feedback from Stef. Basically, to avoid making the user to create 3 objects (1 Rectangle = 2 Points), to specify those fraction values that at the end, the constraints already hold as 4 numbers by separate.
I have another discussion:
Do we search a better name than "fraction" for the API?
May be "ratio"? leftRatio, rightRatio, etc.?
I don't like "proportion" , because it sounds too long and redundant, like [:c | c proportional horizontal leftProportion: 0.5 ]
—
Reply to this email directly, view it on GitHub <#261 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALXHU3GHHSWKTEN7F5AJNF3XIC5L3ANCNFSM6AAAAAAYPNRURE> .
You are receiving this because you commented. <https://github.com/notifications/beacon/ALXHU3GA5HIPTKU2PE2B32LXIC5L3A5CNFSM6AAAAAAYPNRURGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS5IAYLY.gif> Message ID: ***@***.*** ***@***.***> >
|
@labordep I like your idea!!! |
Suggested by Pierre
Well, so let's merge! |
Fixes #260
Note: It still doesn't take into account minWidth and minHeight. It should, right?
Also, eventually a negative extent.
So another commit must work on those.