Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Error handling #409

Merged
merged 2 commits into from Jan 27, 2024
Merged

Improving the Error handling #409

merged 2 commits into from Jan 27, 2024

Conversation

tesonep
Copy link
Contributor

@tesonep tesonep commented Jan 23, 2024

  • Better handling exceptions in the events and in the defer actions.
  • Fixing the universe
  • Adding tests

@tinchodias
Copy link
Collaborator

This may close #396 and #406

@tinchodias
Copy link
Collaborator

Reminder: Need to check what happens with an animation that signals an error on each pulse

@tinchodias tinchodias merged commit ee22c66 into dev-1.0 Jan 27, 2024
12 checks passed
@tinchodias tinchodias deleted the loop-handles-errors branch January 27, 2024 04:50
@tinchodias
Copy link
Collaborator

Should have fixed #421 too

@tinchodias
Copy link
Collaborator

This demo with a repeated task with error + a ok repeated task shows that the space tolerates it. The one with error stops its repetition:

s := BlSpace new.
s extent: 100 asPoint.
s show.
s root enqueueTask: (BlRepeatedTaskAction new
	delay: 1 second;
	action: [ self inform: 'bonjour' ]).
s root enqueueTask: (BlRepeatedTaskAction new
	delay: 1 second;
	action: [ 1/0 ])

@tinchodias
Copy link
Collaborator

Still this should be fixed:

testOpeningAnSpaceDeferingAnErrorKeepsLoopRunning

	| aSpace logger |

	UIManager default class = MorphicUIManager 
		ifFalse: [ ^ self skip ].

	hostClass = BlOSWindowSDL2Host 
		ifFalse: [ ^ self skip ].
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants