Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves PharoVMMaker constructors #445

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Improves PharoVMMaker constructors #445

merged 1 commit into from
Jul 26, 2022

Conversation

sebastianconcept
Copy link

@sebastianconcept sebastianconcept commented Jul 21, 2022 •
edited
Loading

Adds to PharoVMMaker the constructors that would allow generating code for individual plugins.
Improves some parameter nammings.
Adds defaults.
Categorizes a couple of methods.

With this merge, you'll be able to do things like:

generate := [ PharoVMMaker withCoInterpreter
  internal: #() external: #(HelloWorldPlugin);
  generateExternalPlugins ].

generate value.

Adds to PharoVMMaker the constructors that would allow generating cod…
195e0cc 
…e for individual plugins.

Improves some parameter namings.
Adds defaults.
Categorizes a couple of methods.
@guillep
Copy link
Member

guillep commented Jul 26, 2022

Sure! I don't see any test, so I'll trust you on this :)

Thanks!
G

@guillep guillep merged commit f8d824c into pharo-project:pharo-9 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianconcept @guillep