add a rule to discourage the usage of World/ActiveWorld

src/GeneralRules/RBUsesWorldGlobalRule.class.st

@@ -0,0 +1,43 @@
+"
+The direct use of the global variables World and ActiveWorld is incorrect. 
+Use ""self currentWorld"" instead.
+"
+Class {
+	#name : #RBUsesWorldGlobalRule,
+	#superclass : #ReNodeBasedRule,
+	#category : #'GeneralRules-Migrated'
+}
+
+{ #category : #accessing }
+RBUsesWorldGlobalRule class >> uniqueIdentifierName [
+	"This number should be unique and should change only when the rule completely change semantics"
+
+	^'UsesWorldGlobalRule'
+]
+
+{ #category : #running }
+RBUsesWorldGlobalRule >> check: aNode forCritiquesDo: aCriticBlock [
+
+	(aNode isVariable 
+		and: [ aNode isGlobal 
+		and: [ #(#World #ActiveWorld) includes: aNode name ] ])
+		ifFalse: [ ^ self ].
+
+	aCriticBlock cull: (self critiqueFor: aNode)
+]
+
+{ #category : #accessing }
+RBUsesWorldGlobalRule >> group [
+	^ 'Bugs'
+]
+
+{ #category : #accessing }
+RBUsesWorldGlobalRule >> name [
+	^ 'Uses World/ActiveWorld directly'
+]
+
+{ #category : #accessing }
+RBUsesWorldGlobalRule >> severity [
+
+	^ #warning
+]