Skip to content

Commit

Permalink
Some more cleanings.
Browse files Browse the repository at this point in the history
  • Loading branch information
jecisc committed Mar 27, 2019
1 parent 3567438 commit 817945f
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 25 deletions.
13 changes: 7 additions & 6 deletions src/Athens-Morphic/AthensParagraph.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,18 @@ AthensParagraph >> extent [

{ #category : #'as yet unclassified' }
AthensParagraph >> extraSelectionChanged [
"
"
refreshExtraSelection := true
"

self flag: #foo
self flag: #pharoToRemove "This method is only needed for TextMorphForEditView. This class is planned for removal with PluggableTextMorph. When it will be removed, this class can probably be cleaned."
]

{ #category : #'as yet unclassified' }
AthensParagraph >> findReplaceSelectionRegex: aRegex [
" findReplaceSelectionRegex := aRegex. "
self flag: #foo
" findReplaceSelectionRegex := aRegex. "

self flag: #pharoToRemove "This method is only needed for TextMorphForEditView. This class is planned for removal with PluggableTextMorph. When it will be removed, this class can probably be cleaned."
]

{ #category : #'as yet unclassified' }
Expand All @@ -104,8 +104,9 @@ AthensParagraph >> positionWhenComposed: pos [

{ #category : #'as yet unclassified' }
AthensParagraph >> secondarySelection: aSubstring [
" secondarySelection := aSubstring."
self flag: #foo.
" secondarySelection := aSubstring."

self flag: #pharoToRemove "This method is only needed for TextMorphForEditView. This class is planned for removal with PluggableTextMorph. When it will be removed, this class can probably be cleaned."
]

{ #category : #'as yet unclassified' }
Expand Down
38 changes: 19 additions & 19 deletions src/Morphic-Base/SystemProgressMorph.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,11 @@ SystemProgressMorph class >> enable [
]

{ #category : #'job subscription' }
SystemProgressMorph class >> endJob: aJobEnd [
SystemProgressMorph class >> endJob: aJobEnd [
| bars |
self flag: #toFix. "camillo I need help"
self flag: #pharoFixMe. "camillo I need help"
bars := self uniqueInstance bars.
bars isEmpty
ifFalse: [ self uniqueInstance close: bars last ]
bars isEmpty ifFalse: [ self uniqueInstance close: bars last ]
]

{ #category : #examples }
Expand Down Expand Up @@ -157,16 +156,20 @@ SystemProgressMorph class >> show: aJob [

{ #category : #'instance creation' }
SystemProgressMorph class >> show: aString from: startNumber to: endNumber [
self flag: 'When we go from Exceptions to announcements, delete this and use show:from:to:during:'.
self flag: #pharoFixMe. "When we go from Exceptions to announcements, delete this and use show:from:to:during:"

^ self uniqueInstance show: aString from: startNumber to: endNumber.
^ self uniqueInstance show: aString from: startNumber to: endNumber
]

{ #category : #'instance creation' }
SystemProgressMorph class >> show: aString from: startNumber to: endNumber during: aBlock [
self flag: 'When we go from Exceptions to announcements, this will be the primary entry point'.
self flag: #pharoFixMe. "When we go from Exceptions to announcements, this will be the primary entry point"

^ self uniqueInstance show: aString from: startNumber to: endNumber during: aBlock.
^ self uniqueInstance
show: aString
from: startNumber
to: endNumber
during: aBlock
]

{ #category : #'job subscription' }
Expand Down Expand Up @@ -349,33 +352,30 @@ SystemProgressMorph >> setDefaultParameters [

{ #category : #private }
SystemProgressMorph >> show: aJob [

| progressMorph |
self flag: #pharoFixMe. "When we go from Exceptions to announcements, delete this and use show:from:to:during:"

self flag: 'When we go from Exceptions to announcements, delete this and use show:from:to:during:'.

progressMorph := self addItemShowing: aJob.

self openInWorld.
self updateWidth.
^ progressMorph.

^ progressMorph
]

{ #category : #private }
SystemProgressMorph >> show: aString from: startNumber to: endNumber [

| progressMorph |
self flag: 'When we go from Exceptions to announcements, delete this and use show:from:to:during:'.
self flag: #pharoFixMe. "When we go from Exceptions to announcements, delete this and use show:from:to:during:"

self openInWorld.
progressMorph := self addItemShowing: aString from: startNumber to: endNumber.

self
self
refresh;
reposition.
^ progressMorph.

^ progressMorph
]

{ #category : #private }
Expand Down

0 comments on commit 817945f

Please sign in to comment.