Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DarkTheme depends on Shout! #2261

Closed
Ducasse opened this issue Jan 16, 2019 · 1 comment · Fixed by #3210
Closed

DarkTheme depends on Shout! #2261

Ducasse opened this issue Jan 16, 2019 · 1 comment · Fixed by #3210
Assignees
@estebanlm
Labels
Project: Graphics Athens, Bloc, Morphic, Fonts, etc. Type: Cleanup Type: Enhancement

Comments

@Ducasse
Copy link
Member

Ducasse commented Jan 16, 2019

shStyleTable

^SHRBTextStyler darkStyleTable

and
UITheme class>>
...

self class environment at: #SHPreferences ifPresent: [ :shPreferences |
shPreferences setStyleTable: aUITheme shStyleTable ].
...

There is something wrong in terms of cyclic references.
@Ducasse Ducasse added Type: Enhancement Type: Cleanup Project: Graphics Athens, Bloc, Morphic, Fonts, etc. labels Jan 16, 2019
@estebanlm
Copy link
Member

well, technically... all UITheme has it :)

estebanlm added a commit to estebanlm/pharo that referenced this issue Apr 19, 2019
@estebanlm
removing dependency with Shout
198c4ff 
Fixes pharo-project#2261
@estebanlm estebanlm mentioned this issue Apr 19, 2019
Merged
@estebanlm estebanlm self-assigned this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebanlm estebanlm

Labels
Project: Graphics Athens, Bloc, Morphic, Fonts, etc. Type: Cleanup Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2261-DarkTheme-depends-on-Shout estebanlm/pharo
2 participants
@Ducasse @estebanlm