Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish between instance-side and class-side in method template #2817

Closed
MarcusDenker opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@MarcusDenker
Copy link
Member

MarcusDenker commented Mar 14, 2019

This is https://pharo.fogbugz.com/f/cases/22748/distinguish-between-instance-side-and-class-side-in-method-template

A new method #sourceCodeTemplateFor: was introduced, it is not used in Pharo8.

better solution: implement #sourceCodeTemplate on Metaclass instead.

==> works, no API change needed.

The PR should remove sourceCodeTemplateFor: and rewrite the test to test #sourceCodeTemplate

MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Mar 14, 2019

fixes pharo-project#2817
- introduce different #sourceCodeTemplate for class side
- remove #sourceCodeTemplateFor:
- move  sourceCodeTemplate out of Compiler, it is independed of the specific compiler and just an accessor
- move test to BehaviorTest

@cdlm cdlm added the review label Mar 14, 2019

@bencoman

This comment has been minimized.

Copy link
Contributor

bencoman commented Mar 14, 2019

better solution: implement #sourceCodeTemplate on Metaclass instead.

That is the obvious solution and I vaguely remember trying it first but there was "some" problem with it, but sorry I can't remember what - maybe my memory is mistaken.

@cdlm cdlm removed the review label Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.