Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Halt from Kernel #3256

Closed
jecisc opened this issue Apr 26, 2019 · 6 comments
Closed

Remove Halt from Kernel #3256

jecisc opened this issue Apr 26, 2019 · 6 comments

Comments

@jecisc
Copy link
Member

jecisc commented Apr 26, 2019

I propose as a first step to move Halt from Kernel and put it in Debugging-Core.

@stale
Copy link

stale bot commented Jan 1, 2020

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. If no further activity occurs, it might be closed. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software
Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…

@stale stale bot added the stale label Jan 1, 2020
@bencoman
Copy link
Contributor

bencoman commented Jan 2, 2020

Halt seems deeply intertwined with the kernel.
Its removal from Context >> runUntilErrorOrReturnFrom: introduced a regression with a problem stepping-over "self halt" in the debugger, fixed here... #5289

Perhaps the class itself can remain but be slimmed down to move the majority of code to Debugging extensions that live outside the Kernel ?

@stale stale bot removed the stale label Jan 2, 2020
@StevenCostiou StevenCostiou added this to To do in Debugger and Debugging via automation Jan 7, 2021
@StevenCostiou StevenCostiou moved this from To do to In progress in Debugger and Debugging Jan 7, 2021
@StevenCostiou
Copy link
Collaborator

@MarcusDenker what do you think about this issue?
@jecisc could you explain why removing halt from the kernel?

Should we close this issue?

@jecisc
Copy link
Member Author

jecisc commented Jan 7, 2021

One of Pharo's goal is to be more modular and to have the smallest core possible for the bootstrap.

Halt is a debugging utility. Kernel does not need it and it can be loaded during a later step of the bootstrap probably.

@StevenCostiou
Copy link
Collaborator

Thanks Cyril, I understand.
I remove debugger tags from this issue, as it is more related to modularity and not to the debugger and debugging system themselves.

@guillep
Copy link
Member

guillep commented Jan 27, 2023

This is a larger task than a bug in itself, I propose we write the idea down on a wiki page with potential projects.

@guillep guillep closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants