Adding halt to the list of captured exceptions when single stepping #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose? (present in P5, removed in P6) - UnhandledError cannot be catched, as it is not a subclass of Error
estebanlm
reviewed
Dec 3, 2019
src/Kernel/Context.class.st
Outdated
| @@ -1672,10 +1672,10 @@ Context >> runUntilErrorOrReturnFrom: aSender [ | |||
| "Insert ensure and exception handler contexts under aSender" | |||
| error := nil. | |||
| context := aSender insertSender: (Context | |||
| contextOn: Error do: [:ex | | |||
| contextOn: Error, Halt do: [:ex | | |||
| error ifNil: [ | |||
| "this is ugly but it fixes the side-effects of not sending an Unhandled error on Halt" | |||
There was a problem hiding this comment.
if you remove the isKindOf:, this comment still has sense? it applies?
There was a problem hiding this comment.
Hmmm indeed, that comment could be removed.
tesonep
approved these changes
Dec 3, 2019
MarcusDenker
approved these changes
Dec 9, 2019
This was referenced Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halt was missing from the catched exceptions, was it removed on pur…pose? (present in P5, removed in P6)
UnhandledError cannot be catched, as it is not a subclass of Error
#fixes stepping on halt is breaking debugging experience #5280