-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Browser > Changes - FileList DNU #readStream #3302
Comments
I was doing up a PR but find the FileList>>readOnlyStream is using deprecated FileStream
so another solution is required for Pharo 8. I'm not familiar with what the planned replacement should be so I'll have to leave it to others. |
But the reference inside FileList is already a FileReference, so the fix is to just ask the reference for its readStream |
…er-DNU-#readStream Fixes #3302 for Pharo 7.
@bencoman can I close this issue now? |
Thx @estebanlm. I've confirmed its fixed in build... Side thought... only if its simple to do... it could be good for the "development versions" shown in Launcher to follow the releases, so this build might have been named... |
@estebanlm So I was slow to notice that its been fixed in Pharo7.0.3. |
==> Instance of FileList did not understand #readStream
Fix is to change that to #readOnlyStream as hinted at... https://pharo.fogbugz.com/f/cases/19859
And same for
ExternalBrowser>>serviceBrowseCode
(P.S. Its strange that case indicates it was integrated but it seems to be missing.)
Can this also be backported for the next Pharo 7 minor release. It would be pretty jarring for a newcomer browsing around features.
The text was updated successfully, but these errors were encountered: