Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3302 for Pharo 7. #3340

Conversation

@bencoman
Copy link
Contributor

commented May 13, 2019

(Trying again targeting Pharo7.0 branch rather than whoops targeting Pharo8.0.)

In Pharo 7.0.3...
Tools > File Browser
Select an ST file
Click
==> Instance of FileList did not understand #readStream (issue #3302)

A debugger appearing for clicking a button in a standard tool provides a poor impression to newcomers. The fix is simple replacing #readStream call with #readOnlyStream, so please consider merging this for the next Pharo 7 point release.

This is a backport of Pharo 8 issue #3301, which may need some additional work since FileList >> readOnlyStream depends on deprecated FileStream.

@bencoman

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@Ducasse This looks better with just 2 file changes.

@estebanlm estebanlm merged commit 87d2836 into pharo-project:Pharo7.0 May 21, 2019

1 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details

@bencoman bencoman deleted the bencoman:Pharo-7-Fixes-#3302-File-Browser-DNU-#readStream branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.