Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pcRange on Context using #sourceNodeExecuted #4735

Closed
MarcusDenker opened this issue Sep 26, 2019 · 0 comments · Fixed by #4740
Closed

Implement pcRange on Context using #sourceNodeExecuted #4735

MarcusDenker opened this issue Sep 26, 2019 · 0 comments · Fixed by #4740

Comments

@MarcusDenker
Copy link
Member

We have right now #pcRangeContextIsActive: on Context. This means that the highlight of the debugger depends on the UI to tell if the context is the top most context or not.

But we have already #sourceNodeExecuted, which returns exactly the right AST node.

We thus could implement pcRange on Context as:

^self sourceNodeExecuted debugHighlightRange

and remove quite some code that is not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant