-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover lost changes does not apply changes in right order #4875
Comments
happens in Pharo 7.0 |
I fixed it in 8.0, @demarey Could we still backport the fix to 7.0? it would be great. |
@tinchodias Yes please! |
@tinchodias Very nice if already fixed. If possible, it would be nice to have it for pharo 7.0 too |
I have the fix ready to commit and push. Could you change the milestone of the issue? Not sure how to do it. |
Fixed "lost changes detector" and added a test. Also refactored a bit the already present tests.
Done, please review #4908. I've written my steps to test it. |
@tinchodias A bit late, but now works as expected. |
After an image crash, if you click yes on "recover lost changes" dialog, then you select changes and click accept => changes are not applied in the right order.
Epicea tries to declare methods before their class.
Simple case to reproduce:
Create a class Foo, then create #a, #b, #c, #d, #e methods. Make the image crash (on OS X full window -> sleep -> wake up).
=> errors saying that class Foo is not found while trying to declare methods.
What is strange is that if you say no to the recover lost changes window and you use 'code changes' tool from the menu, changes are applied in the right order from the tool.
@tinchodias an idea of what happens?
The text was updated successfully, but these errors were encountered: