Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover lost changes does not apply changes in right order #4875

Closed
demarey opened this issue Oct 10, 2019 · 7 comments
Closed

Recover lost changes does not apply changes in right order #4875

demarey opened this issue Oct 10, 2019 · 7 comments

Comments

@demarey
Copy link
Contributor

demarey commented Oct 10, 2019

After an image crash, if you click yes on "recover lost changes" dialog, then you select changes and click accept => changes are not applied in the right order.
Epicea tries to declare methods before their class.

Simple case to reproduce:
Create a class Foo, then create #a, #b, #c, #d, #e methods. Make the image crash (on OS X full window -> sleep -> wake up).
=> errors saying that class Foo is not found while trying to declare methods.

What is strange is that if you say no to the recover lost changes window and you use 'code changes' tool from the menu, changes are applied in the right order from the tool.

@tinchodias an idea of what happens?

@demarey demarey added this to the 8.0.0 milestone Oct 10, 2019
@demarey
Copy link
Contributor Author

demarey commented Oct 10, 2019

happens in Pharo 7.0
Cannot check in Pharo 8 because of #4876

@tinchodias
Copy link
Contributor

I fixed it in 8.0, @demarey Could we still backport the fix to 7.0? it would be great.

@jecisc
Copy link
Member

jecisc commented Oct 10, 2019

@tinchodias Yes please!

@demarey
Copy link
Contributor Author

demarey commented Oct 10, 2019

@tinchodias Very nice if already fixed. If possible, it would be nice to have it for pharo 7.0 too

@tinchodias
Copy link
Contributor

I have the fix ready to commit and push. Could you change the milestone of the issue? Not sure how to do it.

tinchodias added a commit to tinchodias/pharo that referenced this issue Oct 14, 2019
Fixed "lost changes detector" and added a test. Also refactored a bit the already present tests.
@tinchodias
Copy link
Contributor

Done, please review #4908. I've written my steps to test it.

@demarey demarey removed this from the 8.0.0 milestone Oct 23, 2019
@demarey
Copy link
Contributor Author

demarey commented Oct 23, 2019

@tinchodias A bit late, but now works as expected.
Thanks a lot

@demarey demarey closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants