Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHRBTextStyler doesn't format comments on root AST node #5818

Closed
j-brant opened this issue Feb 29, 2020 · 0 comments · Fixed by #9083
Closed

SHRBTextStyler doesn't format comments on root AST node #5818

j-brant opened this issue Feb 29, 2020 · 0 comments · Fixed by #9083
Labels
Project: Compiler

Comments

@j-brant
Copy link
Contributor

j-brant commented Feb 29, 2020

Compare the formatting of the following two expressions in a playground: "comment"3 and "comment"3+4. The latter shows the comment formatted correctly and the former shows the comment without any formatting. The comments are formatted by the code in SHRBTextStyler>>visitNode: and SHRBTextStyler>>style:ast: directly calls the acceptVisitor: method on the AST node instead of calling #visitNode: on self. Method comments are handled specially by #visitMethodNode: so they always are formatted even though they are at the top level.
@weekly-digest weekly-digest bot mentioned this issue Mar 2, 2020
Closed
@MarcusDenker MarcusDenker mentioned this issue Feb 2, 2021
Closed
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Apr 16, 2021
@MarcusDenker
This PR implements the fix described in the issue tracker entry.
5684fcc 
I added the two examples as tests, the testArgumentStylingExpressionWithComment2 was failing without the fix and is now green.

fixes pharo-project#5818
fixes pharo-project#7075
@MarcusDenker MarcusDenker mentioned this issue Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project: Compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5818-SHRBTextStyler-doesnt-format-comments-on-root-AST-node MarcusDenker/pharo
2 participants
@Ducasse @j-brant