Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glamourValueWithArgs: without duplication logic #6839

Closed
Ducasse opened this issue Jul 13, 2020 · 1 comment · Fixed by #7227
Closed

glamourValueWithArgs: without duplication logic #6839

Ducasse opened this issue Jul 13, 2020 · 1 comment · Fixed by #7227

Comments

@Ducasse
Copy link
Member

Ducasse commented Jul 13, 2020

glamourValueWithArgs: anArray 
	"This is the same as valueWithPossibleArgs: from squeak. 
	Unfortunately, VW's cullValue: is incompatible." 
	 
	self numArgs = 0 ifTrue: [^self value]. 
	self numArgs = anArray size ifTrue: [^self valueWithArguments: anArray]. 
	self numArgs > anArray size 
		ifTrue: 
			[^self 
				valueWithArguments: anArray , (Array new: self numArgs - anArray size)]. 
	^self 
		valueWithArguments: 
			(anArray 
				copyFrom: 1 
				to: self numArgs)

the body of this method can just be

^ self valueWithPossibleArgs: anArray

@estebanlm
Copy link
Member

I would not care about this at all.
We are going to remove the whole glamour thingy, after all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants