Deprecate #beginsWithEmpty:caseSensitive. Users should use beginsWith… #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:caseSensitive which is consistent to simple #beginWith: method.
dionisiydk
commented
Sep 21, 2021
| { #category : #tests } | ||
| StringTest >> testBeginsWithEmptyCaseSensitive [ | ||
|
|
||
| self deny: ('éèàôüößäóñíá' beginsWithEmpty: 'ß' caseSensitive: true). |
There was a problem hiding this comment.
I found many other StringTests with strange encodings. Not sure what to do with them. But such cleaning required a separate issue
MarcusDenker
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It deprecates String method #beginsWithEmpty:caseSensitive. It was oddly named and it was inconsistent to a simple #beginsWith: analog in case of empty prefix.
Now users should use #beginsWith:caseSensitive and take care about empty prefix on their own side when needed.
The image users are adopted accordingly