10078-To-check-CompiledMethodlocalReadsSelf-does-isFFIMethod-check #10086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the FFI check from #localReadSelf to #usingMethods of SelfVariable - add a test and comment to testReadsSelf. I do not execute an FFI method here to not add a dependency / make this test platform specific - add tests for #usingMethods for self: - check that we can find the test method itself (with the self assert) - check that if we use super, we do not find it - add test to check for a #isFFIMethod that does not read self, but we find it still by #usingMethods of SelfVariable
dionisiydk
reviewed
Oct 7, 2021
|
|
||
| ^ environment allMethods select: [ :method | | ||
| method isFFIMethod or: [ | ||
| method readsSelf and: [ | ||
| method sendsToSuper not or: [ | ||
| method ast variableNodes anySatisfy: [ :varNode | |
There was a problem hiding this comment.
Some useful method can be extracted here:
method ast includesVariable: self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10078: