21508-Integrate-Calypso-0103 #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicit version for all dependencies. Calypso version is now 0.10.3.
Strangely lock guard is not working here. But this script works well in Pharo 6. Let's try another way to handle lock signal.
|
Looks like this lock API do not work in Pharo 7. |
But it not works anyway
While locking does not work we can just load required dependency versions
|
No, it's not the lock API that is wrong, you're using it wrong. Also, BaselineOfCalypso is still wrong. We should depend on exact versions on release. baseline: 'ClassAnnotation' with: [
spec
repository: 'github://dionisiydk/ClassAnnotation:v0.3.x';
loads: 'Core' ];
project: 'ClassAnnotationTests' copyFrom: 'ClassAnnotation' with: [
spec loads: 'Tests'];
baseline: 'Commander' with: [
spec repository: 'github://dionisiydk/Commander:v0.5.x' ];
baseline: 'SystemCommands' with: [
spec repository: 'github://dionisiydk/SystemCommands:v0.7.x' ].Moreover, this change is plain wrong: https://github.com/pharo-project/pharo/pull/1037/files We should just load Calypso and not all of its dependencies. We should put the exact versions in the baseline, and you should use lock in your development image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#loadCalypso script is now uses Metacello locking mechanizm to force explicit version for all dependencies.
Calypso version is now 0.10.3.
https://pharo.fogbugz.com/f/cases/21508/Integrate-Calypso-0-10-3