Add commentSourcePointer to ClassDescription #11326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commentSourcePointer is now defined in ClassOrganization, which wastes space. To be able to move it, we first have to add the ivar using a manual PR. Fist step for #10958
MarcusDenker
added
the
Status: Need more work
|
adding the unused var makes two tests fail:
But as the PR is done by manually editing and not loadable, the only way is to merge and fix in a second step the tests |
|
I am merging this and then
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commentSourcePointer is now defined in ClassOrganization, which wastes space.
To be able to move it, we first have to add the ivar using a manual PR.
Fist step for #10958