10041-PlatformIndependentEnvironmentatifAbsent-should-evaluate-absent-block #11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me PlatformIndependentEnvironment is a confusing name. So please at the minimum add a clear comment |
|
I just fixed the issue tracker entry. To me everything else is better to add another issue, as it is another problem. |
"Gets the value of an environment variable called `aKey`. Execute aBlock if absent. As there is nowhere to look up the key just evaluate the given block" - implement setEnv:value: to fullfill the sublass responsibility (it does nothing)
|
I improved the comment a bit more |
|
Yes let us open another issue. |
MarcusDenker
deleted the
10041-PlatformIndependentEnvironmentatifAbsent-should-evaluate-absent-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just implements the method as described in the issue tracker entry
fixes #10041