Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Snippets: extends tests to check notices #13115

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

privat
Copy link
Contributor

@privat privat commented Mar 22, 2023

Another big diff :(

Each code snippet is provided the information about the expected notices (all errors and warnings).
This is the second commit (the big one). Even if the notices are in a condensed form, it's still big.
Note: if you are brave, you can annotate, in the diff, the errors and warning messages you don't expect (or don't like).

Some tests are extended to check that the notices are the right ones (third commit)

This helps to show that there are still some strange error messages and warnings in some configurations.
It's the point of mass testing, you can check many kinds of syntactic variations.

Therefore, I fixed one: statement that starts with a plain closer )}] reported "unexpected token" instead of "missing opener". (last commit)
It also shows that CodeImport do not like dry closing ], but is fine otherwise with ] in found later in the code. It is to de investigated.
But that also shows the benefit of running all snippets on many clients.

I stop here, or the PR will be too huge :)

Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the code and that seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants