Code Snippets: extends tests to check notices #13115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another big diff :(
Each code snippet is provided the information about the expected notices (all errors and warnings).
This is the second commit (the big one). Even if the notices are in a condensed form, it's still big.
Note: if you are brave, you can annotate, in the diff, the errors and warning messages you don't expect (or don't like).
Some tests are extended to check that the notices are the right ones (third commit)
This helps to show that there are still some strange error messages and warnings in some configurations.
It's the point of mass testing, you can check many kinds of syntactic variations.
Therefore, I fixed one: statement that starts with a plain closer
)}]
reported "unexpected token" instead of "missing opener". (last commit)It also shows that CodeImport do not like dry closing
]
, but is fine otherwise with]
in found later in the code. It is to de investigated.But that also shows the benefit of running all snippets on many clients.
I stop here, or the PR will be too huge :)